Replace eth-query with ethjs-query?

[mcmire]

These packages sound the same but they are different.

• eth-query is very simple: it makes a JSON-RPC call to the provider and calls the given callback with an error or the resulting data.
• ethjs-query not only makes a JSON-RPC call to the provider, but it also formats the resulting data according to the spec for the RPC method in question. For instance, if the result is an integer, it converts it from hex format to a BN object. Although, see counterpoint: https://consensys.slack.com/archives/GTQAGKY5V/p1634686296360000?thread_ts=1634676086.354900&cid=GTQAGKY5V

Related issue: #108

[legobeat]

I guess this is not relevant anymore? #852

[mcmire]

I agree that this issue and #852 are mutually exclusive. I made them both because I wasn't sure what our long-term strategy was at the time.

Now that some time has passed, it seems like this issue is definitely relevant: considering that you've recently forked all of the ethjs-* packages, it would seem that we at least want to keep using those packages, which would imply that we don't want to use the eth-* packages.

As for the issue you mentioned, however: is it irrelevant? Perhaps not everyone would agree with the conclusion I gave — there are arguments to be made for not using Ethers for everything — but I think everyone has admitted, or at least hinted, that we ought to use newer libraries, and it sounds like you agree. But perhaps that view has changed?

[MajorLift]

Looks like this could be closed by https://app.zenhub.com/workspaces/shared-libraries-621e46b4d7103800171d1b02/issues/zh/244?

[mcmire]

Ah, yes. The new technical proposals answer this question by suggesting that we merge these two libraries together. Closing this since we can discuss this further within that proposal.