Skip to content

NetworkController: provider -> getProviderAndBlockTracker#1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 7 commits into from
Feb 27, 2023
Merged

NetworkController: provider -> getProviderAndBlockTracker #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d79f84b
Replace provider with getProviderAndBlockTracker
cryptodev-2s Feb 1, 2023
a6f9559
Rely on the TypeScript-converted version of swappable-obj-proxy tempo…
mcmire Feb 22, 2023
347f46d
Fix Yarn constraints to allow for github: references
mcmire Feb 22, 2023
7d81410
Merge branch 'main' into implement-provider-proxy-and-block-track-proxy
mcmire Feb 22, 2023
fcff7b2
Update swappable-obj-proxy reference
mcmire Feb 24, 2023
5508fd8
Bump swappable-obj-proxy to 2.1.0
mcmire Feb 24, 2023
b5616ab
Revert "Fix Yarn constraints to allow for github: references"
mcmire Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/gas-fee-controller/src/GasFeeController.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,8 +11,8 @@ import type {
NetworkControllerGetEthQueryAction,
NetworkControllerGetProviderConfigAction,
NetworkControllerProviderConfigChangeEvent,
NetworkController,
NetworkState,
ProviderProxy,
} from '@metamask/network-controller';
import {
fetchGasEstimates,
Expand DownExpand Up@@ -303,7 +303,7 @@ export class GasFeeController extends BaseControllerV2<
getCurrentNetworkLegacyGasAPICompatibility: () => boolean;
getCurrentAccountEIP1559Compatibility?: () => boolean;
getChainId?: () => `0x${string}` | `${number}` | number;
getProvider: () => NetworkController['provider'];

@mcmiremcmireFeb 21, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider property on NetworkController went away, so we can't use that as a type here. That said, I don't think this was right anyway, it's better to export a type from NetworkController.

getProvider: () => ProviderProxy;
onNetworkStateChange?: (listener: (state: NetworkState) => void) => void;
legacyAPIEndpoint?: string;
EIP1559APIEndpoint: string;
Expand Down
1 change: 1 addition & 0 deletions packages/network-controller/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@
"dependencies": {
"@metamask/base-controller": "workspace:^",
"@metamask/controller-utils": "workspace:^",
"@metamask/swappable-obj-proxy": "^2.1.0",
"async-mutex": "^0.2.6",
"babel-runtime": "^6.26.0",
"eth-json-rpc-infura": "^5.1.0",
Expand Down
Loading