Skip to content

Release 42.0.0 - #1108

Merged
hmalik88 merged 8 commits into
mainfrom
release/42.0.0
Feb 17, 2023
Merged

Release 42.0.0#1108
hmalik88 merged 8 commits into
mainfrom
release/42.0.0

Conversation

@hmalik88

Copy link
Copy Markdown
Contributor

This release includes a breaking change to controller-utils, phishing-controller and transaction-controller. isomorphic-fetch has been now removed. This was breaking snaps that implicitly import controller-utils if they did not have a network endowment.

@hmalik88
hmalik88 requested a review from a team as a code ownerFebruary 17, 2023 17:59
@Gudahtt

Copy link
Copy Markdown
Member

Hmm, we need to release all packages I think. If not, they'll still be using the old version of controller-utils with isomorphic-fetch.

Comment threadpackages/transaction-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md
Comment threadpackages/address-book-controller/CHANGELOG.md
mcmire
mcmire previously approved these changes Feb 17, 2023

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment threadpackages/gas-fee-controller/CHANGELOG.md
Gudahtt
Gudahtt previously requested changes Feb 17, 2023

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from a single missing change entry!

@GudahttGudahtt changed the title Release/42.0.0Release 42.0.0Feb 17, 2023
Comment threadpackages/gas-fee-controller/CHANGELOG.md

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hmalik88
hmalik88 merged commit dc9eb67 into mainFeb 17, 2023
@hmalik88
hmalik88 deleted the release/42.0.0 branch February 17, 2023 22:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hmalik88@Gudahtt@mcmire