Skip to content

Use job-based Travis config, test CI install - #125

Merged
whymarrh merged 3 commits into
MetaMask:developfrom
whymarrh:travis-ci-jobs
Jul 2, 2019
Merged

Use job-based Travis config, test CI install#125
whymarrh merged 3 commits into
MetaMask:developfrom
whymarrh:travis-ci-jobs

Conversation

@whymarrh

Copy link
Copy Markdown
Contributor

This PR updates the Travis config to:

  1. Use the job-based config[1]
  2. Test npm ci in addition to npm install

This introduces two jobs, one based on a regular `npm install` and one based
on `npm ci`, the latter just to confirm that a ci install produces a correct
install that passes the test suite.
@whymarrh

Copy link
Copy Markdown
ContributorAuthor

The 2nd job fails pending #123

@whymarrh

Copy link
Copy Markdown
ContributorAuthor

I'll rebase this on develop once #123 is handled

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #125 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #125 +/- ##
======================================
Coverage 100% 100% ======================================
Files 21 21 Lines 1432 1432 Branches 194 194 ======================================
Hits 1432 1432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08c229...208c688. Read the comment docs.

@whymarrh
whymarrh merged commit e1ef426 into MetaMask:developJul 2, 2019
@whymarrh
whymarrh deleted the travis-ci-jobs branch July 2, 2019 17:14
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v3.0.0...v3.1.0)
---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/MetaMask/utils/releases)
- [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md)
- [Commits](MetaMask/utils@v3.3.1...v3.4.0)
---
updated-dependencies:
- dependency-name: "@metamask/utils"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
We are attempting to convert `eth-json-rpc-infura`, which relies on this
package, to TypeScript, and TypeScript is reporting errors resolving the
definition file for this package due to the types for
`eth-block-tracker` not being properly available. Moving it to
`dependencies` addresses this.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@whymarrh@codecov-io@bitpshr