Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary mock from provider API test helper - #1304
Merged
Conversation
mcmire
approved these changes
May 2, 2023
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Probably just a copy-paste sort of thing from the extension side, where this works a bit differently.
Gudahtt
commented
May 2, 2023
MemberAuthor
Oh it was critical prior to #1236, but I missed this change in that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An unnecessary mock has been removed from a helper function used by network client tests. The
getEIP1559Compatibilityfunction is only called as part oflookupNetwork(which is also mocked) as of #1236, so this has been redundant since then.Relates to #1116
Changes
None
References
Relates to #1116
Checklist