Uh oh!
There was an error while loading. Please reload this page.
Remove networkid from network controller - #1564
Closed
BelfordZ wants to merge 2 commits into
Closed
Conversation
BelfordZ
marked this pull request as draft
July 28, 2023 21:38
| onNetworkStateChange((networkState) => { | ||
| this.resetState(); | ||
| // should be checking chainid, not networkId | ||
| const currentNetwork = networkState.networkId; |
| // should be checking chainid, not networkId | ||
| const currentNetwork = networkState.networkId; | ||
| if ( | ||
| isKnownNetworkId(currentNetwork) && |
BelfordZ
commented
Oct 12, 2023
ContributorAuthor
replaced by #1633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
@metamask/package-a@metamask/package-bChecklist