Uh oh!
There was an error while loading. Please reload this page.
Feature: sign typed message v4 - #161
Merged
Merged
Conversation
codecov-io
commented
Oct 22, 2019
Codecov Report
@@ Coverage Diff @@## develop #161 +/- ##
======================================
Coverage 100% 100% ======================================
Files 23 23 Lines 1497 1498 +1 Branches 209 209 ======================================
+ Hits 1497 1498 +1
Continue to review full report at Codecov.
|
Mrtenz pushed a commit
that referenced
this pull request
Oct 16, 2025
Mrtenz pushed a commit
that referenced
this pull request
Oct 16, 2025
Bumps [@metamask/eth-sig-util](https://github.com/MetaMask/eth-sig-util) from 5.0.0 to 5.0.2. - [Release notes](https://github.com/MetaMask/eth-sig-util/releases) - [Changelog](https://github.com/MetaMask/eth-sig-util/blob/main/CHANGELOG.md) - [Commits](MetaMask/eth-sig-util@v5.0.0...v5.0.2) --- updated-dependencies: - dependency-name: "@metamask/eth-sig-util" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
Both the extension and mobile have been on Node 16 for a while now, so this should be safe to do. Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for sign typed messages v4 in KeyringController's method
signTypedMessageusing the new method frometh-sig-util. Added and updated tests, instead of checking signatures againstnon-empty, tests are now checking against a signature recovered account.Related MetaMask/metamask-mobile#1055