Skip to content

Migrate PhishingController to BaseControllerV2 - #1705

Merged
GuillaumeRx merged 5 commits into
mainfrom
gr/migrate-phishing-controller-v2
Sep 26, 2023
Merged

Migrate PhishingController to BaseControllerV2#1705
GuillaumeRx merged 5 commits into
mainfrom
gr/migrate-phishing-controller-v2

Conversation

@GuillaumeRx

@GuillaumeRxGuillaumeRx commented Sep 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation

This migrates the PhishingController to BaseControllerV2

Changelog

Added

  • Add maybeUpdateState and testOrigin actions

Changed

  • BREAKING:PhishingController now inherits from BaseControllerV2
  • BREAKING:PhishingControllernow expects a messenger option (and corresponding type PhishingControllerMessenger is now available)
  • BREAKING: The constructor takes a single argument, an options bag, instead of three arguments
  • BREAKING: The disabled configuration is no longer supported

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Gudahtt
Gudahtt reviewed Sep 22, 2023
View reviewed changes
Comment threadpackages/phishing-controller/src/PhishingController.ts Outdated
Gudahtt
Gudahtt reviewed Sep 22, 2023
View reviewed changes
Comment threadpackages/phishing-controller/src/PhishingController.ts Outdated
@GuillaumeRx
GuillaumeRxforce-pushed the gr/migrate-phishing-controller-v2 branch from 67f9d19 to 7adc61cCompareSeptember 25, 2023 10:58
@GuillaumeRx
GuillaumeRx marked this pull request as ready for review September 25, 2023 10:58
@GuillaumeRx
GuillaumeRx requested a review from a team as a code ownerSeptember 25, 2023 10:58
Gudahtt
Gudahtt approved these changes Sep 25, 2023
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are a few more changes to mention though:

Added

  • Add maybeUpdateState and testOrigin actions

Changed

  • BREAKING: The disabled configuration is no longer supported

@GuillaumeRx
GuillaumeRxforce-pushed the gr/migrate-phishing-controller-v2 branch from 7adc61c to 6fa215eCompareSeptember 25, 2023 17:38
@GuillaumeRx
GuillaumeRxforce-pushed the gr/migrate-phishing-controller-v2 branch from 6fa215e to 5632131CompareSeptember 25, 2023 20:24
@GuillaumeRx
GuillaumeRxforce-pushed the gr/migrate-phishing-controller-v2 branch from 5632131 to b339160CompareSeptember 26, 2023 12:44
@GuillaumeRx
GuillaumeRx merged commit 22786ef into mainSep 26, 2023
@GuillaumeRx
GuillaumeRx deleted the gr/migrate-phishing-controller-v2 branch September 26, 2023 13:11
@mcmiremcmire mentioned this pull request Oct 11, 2023
Closed
@mcmiremcmire mentioned this pull request Nov 22, 2023
Closed
@MajorLiftMajorLift mentioned this pull request Dec 6, 2023
Closed
29 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GudahttGudahttGudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeRx@Gudahtt