Skip to content

Release 78.0.0 - #1708

Merged
Gudahtt merged 33 commits into
mainfrom
release/78.0.0
Sep 26, 2023
Merged

Release 78.0.0#1708
Gudahtt merged 33 commits into
mainfrom
release/78.0.0

Conversation

@OGPoyraz

@OGPoyrazOGPoyraz commented Sep 25, 2023

Copy link
Copy Markdown
Member

See change logs

@OGPoyraz
OGPoyraz requested a review from a team as a code ownerSeptember 25, 2023 10:09
@mikesposito

mikesposito commented Sep 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

We should change the title of this PR to Release 78.0.0 for the CI to properly flag this as a release

mikesposito
mikesposito reviewed Sep 25, 2023
View reviewed changes
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Comment on lines +11 to +26
- **BREAKING**: `TokensController.addToken` now accepts a single options object
```
{
address: string;
symbol: string;
decimals: number;
name?: string;
image?: string;
interactingAddress?: string;
networkClientId?: NetworkClientId;
}
```
- **CHANGED**: `TokensController.addToken` will use the chain ID value derived from state for `networkClientId` if provided
- **CHANGED**: `TokensController.addTokens` now accepts an optional `networkClientId` as the last parameter
- **CHANGED**: `TokensController.addTokens` will use the chain ID value derived from state for `networkClientId` if provided
- **CHANGED**: `TokensController.watchAsset` options now accepts optional `networkClientId` which is used to get the ERC-20 token name if provided

@mikespositomikespositoSep 25, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link PRs related to these changes?

@OGPoyrazOGPoyrazSep 25, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a4313b4

@OGPoyrazOGPoyraz changed the title Release/78.0.0Release 78.0.0Sep 25, 2023
@OGPoyraz

OGPoyraz commented Sep 25, 2023

Copy link
Copy Markdown
MemberAuthor

We should change the title of this PR to Release 78.0.0 for the CI to properly flag this as a release

Thanks @mikesposito

jiexi
jiexi previously approved these changes Sep 25, 2023
View reviewed changes

@jiexijiexi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamask/asset-controllers LGTM. Thank you for cutting this release 💪

Gudahtt
Gudahtt reviewed Sep 25, 2023
View reviewed changes
Comment threadpackages/keyring-controller/CHANGELOG.md
Gudahtt
Gudahtt reviewed Sep 25, 2023
View reviewed changes
Comment threadpackages/assets-controllers/CHANGELOG.md
@Gudahtt

Gudahtt commented Sep 25, 2023

Copy link
Copy Markdown
Member

#1633 has been merged now as well, which includes many breaking changes. We'll need to expand the scope of this release to include a few more things

@jiexi

jiexi commented Sep 25, 2023

Copy link
Copy Markdown
Member

I'm working on getting #1633 included in this release right now

@jiexi
jiexi requested a review from a team as a code ownerSeptember 25, 2023 21:20
@jiexi@Gudahtt
Update packages/assets-controllers/CHANGELOG.md
0cf5f03
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
Gudahtt reviewed Sep 25, 2023
View reviewed changes
Comment threadpackages/address-book-controller/CHANGELOG.md
Gudahtt
Gudahtt reviewed Sep 25, 2023
View reviewed changes
Comment threadpackages/accounts-controller/CHANGELOG.md Outdated
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Gudahtt
Gudahtt reviewed Sep 25, 2023
View reviewed changes
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Gudahtt
Gudahtt previously approved these changes Sep 26, 2023
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt reviewed Sep 26, 2023
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that each of these peer dependency bumps is just called a dependency bump in the change entry, which might be confusing (as that wouldn't normally be breaking). I've added a suggestion to re-word each one to "peer dependency"

Comment threadpackages/transaction-controller/CHANGELOG.md Outdated
Comment threadpackages/selected-network-controller/CHANGELOG.md Outdated
Comment threadpackages/gas-fee-controller/CHANGELOG.md Outdated
Comment threadpackages/ens-controller/CHANGELOG.md Outdated
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
@Gudahtt
Gudahtt merged commit 55b6636 into mainSep 26, 2023
@Gudahtt
Gudahtt deleted the release/78.0.0 branch September 26, 2023 12:20
@mcmiremcmire mentioned this pull request Apr 29, 2026
Draft
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiexijiexijiexi left review comments
@mikespositomikespositomikesposito left review comments
@GudahttGudahttGudahtt approved these changes
@MrtenzMrtenzMrtenz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OGPoyraz@mikesposito@Gudahtt@jiexi@Mrtenz@adonesky1