Skip to content

Update @metamask/utils - #1729

Closed
MajorLift wants to merge 2 commits into
mainfrom
230926-update-@metamask/utils
Closed

Update @metamask/utils#1729
MajorLift wants to merge 2 commits into
mainfrom
230926-update-@metamask/utils

Conversation

@MajorLift

@MajorLiftMajorLift commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

Explanation

Updates @metamask/utils to ^8.1.0 in all subrepos.

References

Changelog

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

  • @metamask/accounts-controller
  • @metamask/address-book-controller
  • @metamask/approval-controller
  • @metamask/assets-controller
  • @metamask/base-controller
  • @metamask/controller-utils
  • @metamask/ens-controller
  • @metamask/gas-fee-controller
  • @metamask/keyring-controller
  • @metamask/message-manager
  • @metamask/network-controller
  • @metamask/notification-controller
  • @metamask/permission-controller
  • @metamask/signature-controller
  • @metamask/transaction-controller

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Comment on lines 9 to 13
export const getPermissionsHandler: PermittedHandlerExport<
GetPermissionsHooks,
undefined,
[],
PermissionConstraint[]
> = {

@MajorLiftMajorLiftSep 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an empty array here to replace undefined as the empty type resolves the compiler errors, but I'd appreciate input on whether this compromises type safety or might cause issues down the road.

@MajorLiftMajorLift mentioned this pull request Sep 26, 2023
3 tasks
@socket-security

socket-securityBot commented Sep 26, 2023

Copy link
Copy Markdown

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@socket-security

socket-securityBot commented Sep 26, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@MajorLift
MajorLiftforce-pushed the 230926-update-@metamask/utils branch from 720ecc3 to 747e2e9CompareSeptember 26, 2023 21:42
@MajorLift
MajorLift marked this pull request as ready for review September 26, 2023 21:52
@MajorLift
MajorLift requested review from a team as code ownersSeptember 26, 2023 21:52
@MajorLiftMajorLift self-assigned this Sep 26, 2023
@MajorLiftMajorLift added dependencies Pull requests that update a dependency file team-wallet-framework Deprecated: Please use `team-core-platform` instead. labels Sep 26, 2023
@legobeat

Copy link
Copy Markdown
Contributor

Closing as duplicate of #1639

@MajorLift
MajorLift deleted the 230926-update-@metamask/utils branch October 17, 2023 19:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency fileteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MajorLift@legobeat