Uh oh!
There was an error while loading. Please reload this page.
Persist currentCurrency from state when re-initialising controller - #173
Conversation
rickycodes
commented
Nov 1, 2019
I'm going to add a test case for this in a moment :) |
Codecov Report
@@ Coverage Diff @@## develop #173 +/- ##
======================================
Coverage 100% 100% ======================================
Files 23 23 Lines 1498 1499 +1 Branches 209 210 +1 ======================================
+ Hits 1498 1499 +1
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
brunobar79
commented
Nov 1, 2019
@estebanmino didn’t we fix this on the app side while passing the initial state to the engine? |
danjm
commented
Nov 1, 2019
Looks good to me but I'll wait for Bruno's comments to be addressed before approving. |
@brunobar79 I removed the version pinning, which should negate the need to update the yarn.lock and npm-shrinkwrap.json (but the next person coming into this might experience the same build issues?) |
* BREAKING: Remove support for Node.js 14,15,17,19 * Drop Node.js 20 support due todevDependency eslint-plugin-jest conflicting version range
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 3.0.3 to 3.4.0. - [Release notes](https://github.com/MetaMask/utils/releases) - [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md) - [Commits](MetaMask/utils@v3.0.3...v3.4.0) --- updated-dependencies: - dependency-name: "@metamask/utils" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
re: MetaMask/metamask-extension#6710
re: the pinning, when I installed this I got tsc
Version 3.6.4which resulted in the following:
builds fine with
3.5.3