Skip to content

Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController - #1735

Merged
montelaidev merged 9 commits into
mainfrom
bump/deps-accounts-controller-27092023
Oct 12, 2023

Conversation

@montelaidev

@montelaidevmontelaidev commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Explanation

Bumps the following dependencies in the AccountsController and fixes a type error introduced by a using the latest snaps controller

Changelog

@metamask/accounts-controller

  • CHANGED:
  • @metamask/eth-snap-keyring updated to ^1.0.0
  • @metamask/keyring-api updated to ^1.0.0
  • @metamask/snaps-controllers updated to ^2.0.1
  • @metamask/snaps-utils updated to ^2.0.1
  • Changed eth-rpc-errors to @metamask/rpc-errors

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidev
montelaidev requested a review from a team as a code ownerSeptember 27, 2023 15:42
@socket-security

socket-securityBot commented Sep 27, 2023

Copy link
Copy Markdown

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
@metamask/snaps-utils3.0.0filesystem, shell+162.44 MBmetamaskbot
@metamask/eth-snap-keyring1.0.0None+3017.1 MBmetamaskbot
@metamask/snaps-controllers1.0.1...3.0.0shell+26/-015.5 MBmetamaskbot
@metamask/keyring-api0.2.5...1.0.0None+28/-3416.8 MBmetamaskbot

@socket-security

socket-securityBot commented Sep 27, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: validate-npm-package-name@5.0.0, @metamask/snaps-controllers@3.0.0, @metamask/snaps-utils@3.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @montelaidev
    montelaidevforce-pushed the bump/deps-accounts-controller-27092023 branch from bff8e0a to 904f204CompareSeptember 27, 2023 15:48
    @montelaidev

    Copy link
    Copy Markdown
    ContributorAuthor

    @SocketSecurity ignore @metamask/snaps-controllers@2.0.1
    @SocketSecurity ignore @metamask/snaps-utils@2.0.1

    legobeat

    This comment was marked as outdated.

    @legobeat
    legobeat self-requested a review September 27, 2023 23:19
    Comment threadpackages/accounts-controller/package.json Outdated
    Comment threadpackages/accounts-controller/package.json Outdated
    legobeat

    This comment was marked as resolved.

    @montelaidevmontelaidev changed the title Bump/deps accounts controller 27092023Bump/deps accounts controller 04102023Oct 4, 2023
    @montelaidevmontelaidev changed the title Bump/deps accounts controller 04102023Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController 04102023Oct 4, 2023
    @legobeatlegobeat changed the title Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsController 04102023Bump/deps @metamask/eth-snap-keyring @metamask/keyring-api @metamask/snaps-controllers @metamask/snaps-utils eth-rpc-errors -> @metamask/rpc-errors in AccountsControllerOct 4, 2023
    @legobeat
    legobeat dismissed their stale reviewOctober 4, 2023 00:59

    synced with main and conflicts resolved

    @legobeat
    legobeat requested a review from a teamOctober 4, 2023 01:00
    @legobeatlegobeat added the dependencies Pull requests that update a dependency file label Oct 4, 2023
    Mrtenz
    Mrtenz previously approved these changes Oct 4, 2023
    @legobeat

    Copy link
    Copy Markdown
    Contributor
    @SocketSecurity ignore validate-npm-package-name@5.0.0
    

    new author ok

    @montelaidev

    Copy link
    Copy Markdown
    ContributorAuthor

    @SocketSecurity ignore @metamask/snaps-controllers@3.0.0
    @SocketSecurity ignore @metamask/snaps-utils@3.0.0

    "outDir": "./dist",
    "rootDir": "./src"
    "rootDir": "./src",
    "skipLibCheck": true

    @montelaidevmontelaidevOct 12, 2023

    Copy link
    Copy Markdown
    ContributorAuthor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ignoring type errors from @metamask/rpc-methods

    node_modules/@metamask/rpc-methods/dist/types/restricted/getLocale.d.ts:46:113 - error TS2344: Type 'void' does not satisfy the constraint 'RestrictedMethodParameters | null'.
    export declare function getImplementation({ getLocale }: GetLocaleMethodHooks): (_args: RestrictedMethodOptions<void>) => Promise<string>;
    

    Will revert once it is fixed

    @montelaidev
    montelaidev merged commit 8f9ca28 into mainOct 12, 2023
    @montelaidev
    montelaidev deleted the bump/deps-accounts-controller-27092023 branch October 12, 2023 14:32
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    dependenciesPull requests that update a dependency file

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @montelaidev@legobeat@Mrtenz@danroc