Uh oh!
There was an error while loading. Please reload this page.
deps(approval-controller): move to @metamask/rpc-errors - #1743
Merged
legobeat merged 2 commits intoOct 2, 2023
Conversation
legobeatforce-pushed
the
deps-rpc-errors-approval-controller
branch
from
September 29, 2023 03:13
0507a4f to
a21caa0Comparelegobeat
marked this pull request as ready for review
September 29, 2023 03:16
3 tasks
legobeat
requested review from
a team, Gudahtt, danroc, jiexi, mikesposito and montelaidevSeptember 29, 2023 03:22
legobeatforce-pushed
the
deps-rpc-errors-approval-controller
branch
from
September 30, 2023 02:44
a21caa0 to
f9b3726CompareMrtenz
approved these changes
Sep 30, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This replaces obsolete
eth-rpc-errorswith@metamask/rpc-errorsin@metamask/approval-controller. This should be coupled with #1639 and can be merged before or after.References
Broken out from
@metamask/rpc-errorsinapproval-controller#1731Blocking
@metamask/json-rpc-engineand@metamask/utils#1724Related
Changelog
@metamask/approval-controllereth-rpc-errorswith@metamask/rpc-errors@metamask/controller-utilseth-rpc-errorsChecklist