Uh oh!
There was an error while loading. Please reload this page.
fix(gas-fee-controller): add missing @metamask/polling-controller - #1748
Merged
adonesky1 merged 3 commits intoOct 2, 2023
Merged
Conversation
legobeatforce-pushed
the
deps-gas-controller-add-polling-controller
branch
from
October 2, 2023 10:52
efd31f3 to
65d0632CompareNew dependencies detected. Learn more about Socket for GitHub ↗︎
|
legobeatforce-pushed
the
deps-gas-controller-add-polling-controller
branch
from
October 2, 2023 10:55
65d0632 to
128ed9cCompare Merged
legobeatforce-pushed
the
deps-gas-controller-add-polling-controller
branch
2 times, most recently
from
October 2, 2023 11:01
f6875b4 to
2ea2909Comparelegobeat
marked this pull request as ready for review
October 2, 2023 11:06
legobeatforce-pushed
the
deps-gas-controller-add-polling-controller
branch
from
October 2, 2023 11:17
2ea2909 to
46d975fCompareOGPoyraz
previously approved these changes
Oct 2, 2023
Gudahtt
reviewed
Oct 2, 2023
| "peerDependencies": { | ||
| "@metamask/network-controller": "^13.0.1" | ||
| "@metamask/network-controller": "^13.0.1", | ||
| "@metamask/polling-controller": "^0.0.0" |
Member
There was a problem hiding this comment.
Welp. This shouldn't be a peerDependency in this case, but the contraints are enforcing it due to the name.
The intention was to enforce that controllers are peerDependencies of each other. But the polling-controller package is not itself a controller, it's a mixin meant to be used by controllers.
Member
There was a problem hiding this comment.
We can add an exception for polling-controller to the constraints here:
Line 308 in a1e1883
We've already added an exception for two other packages
adonesky1force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
October 2, 2023 17:44
f68de2e to
506ef4bCompareadonesky1force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
October 2, 2023 17:45
506ef4b to
fb4260aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds missing dependency introduced in #1673
References
Changelog
Checklist