Skip to content

deps(permission-controller): update to @metamask/json-rpc-engine, @metamask/rpc-errors - #1749

Merged
legobeat merged 11 commits into
MetaMask:mainfrom
legobeat:deps-json-rpc-engine
Oct 3, 2023
Merged

deps(permission-controller): update to @metamask/json-rpc-engine, @metamask/rpc-errors#1749
legobeat merged 11 commits into
MetaMask:mainfrom
legobeat:deps-json-rpc-engine

Conversation

@legobeat

@legobeatlegobeat commented Oct 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation

References

Changelog

@metamask/permission-controller

  • BREAKING: RestrictedMethodParameters no longer accepts void as type.
  • BREAKING: Update from json-rpc-engine@^6.1.0@metamask/json-rpc-engine@^7.1.1
  • CHANGED: Update from eth-rpc-errors@^4.0.2@metamask/rpc-errors@^6.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security

socket-securityBot commented Oct 2, 2023

Copy link
Copy Markdown

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages:@metamask/snaps-utils@1.0.1

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Oct 2, 2023
@legobeat
legobeat marked this pull request as ready for review October 2, 2023 11:14
@legobeat
legobeat requested review from a team as code ownersOctober 2, 2023 11:14
@legobeat
legobeatforce-pushed the deps-json-rpc-engine branch from 79103a1 to 7624988CompareOctober 2, 2023 11:17
Mrtenz
Mrtenz reviewed Oct 2, 2023
View reviewed changes
Comment threadpackages/permission-controller/src/PermissionController.test.ts Outdated
@legobeat
legobeat requested review from a team and MrtenzOctober 2, 2023 12:30
@legobeat
legobeatforce-pushed the deps-json-rpc-engine branch from 0470b2e to 6c34a9eCompareOctober 3, 2023 03:49
Mrtenz
Mrtenz requested changes Oct 3, 2023
View reviewed changes

@MrtenzMrtenz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a lint error

Comment threadpackages/permission-controller/src/PermissionController.test.ts Outdated
@legobeat@Mrtenz
Update packages/permission-controller/src/PermissionController.test.ts
cbad11a
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@legobeat
legobeat requested a review from MrtenzOctober 3, 2023 08:20
@legobeat
legobeat merged commit 2275d38 into MetaMask:mainOct 3, 2023
@legobeatlegobeat mentioned this pull request Oct 19, 2023
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrtenzMrtenzMrtenz approved these changes

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat@Mrtenz