Uh oh!
There was an error while loading. Please reload this page.
eth-json-rpc-provider migration - B1: Remove redundant files and directories. - #1764
Merged
Merged
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages:@metamask/auto-changelog@3.1.0, @types/jest@28.1.7, jest@28.1.3, ts-jest@28.0.8, typedoc@0.23.15 |
MajorLiftforce-pushed
the
231003-migrate-eth-json-rpc-provider-b1
branch
2 times, most recently
from
October 5, 2023 17:44
df4b7dc to
6d9e07dCompareMajorLift added a commit
that referenced
this pull request
Oct 5, 2023
…on-rpc-provider" (#1790) ## Explanation - The contents of `merged-packages/` shouldn't be altered, as it's a temporary directory used for migrating packages into the monorepo. - Any dependency updates for the migration target package need to be handled manually. The migration process involves aligning dependency versions with the monorepo (which may not use the latest version), removing dependencies that are defined in the monorepo root, and removing the `yarn.lock` file from the migration target subpackage. ## Reference - Blocks #1764 - See #1079 (comment) for context on the role of `merged-packages/`.
mcmire
approved these changes
Oct 5, 2023
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements the following incremental step in the process for migrating
eth-json-rpc-providerinto the core monorepo:Phase B: Staging in
migrated-packages/1. Remove files and directories that will be replaced by corresponding files in the monorepo root.
.github/,.git*,scripts/,.depcheckrc.json,.yarn/,.yarnrc.yml,yarn.lock,.editorconfig,.eslint*,.prettier*,.nvm*.src/,tests/,CHANGELOG.md,LICENSE,package.json,README.md,jest.config.js,tsconfig*.json,typedoc.json.See #1551 (comment) for an outline of the entire process.
Blocked by
References
@metamask/eth-json-rpc-providerto core monorepo #1685eth-json-rpc-providerinto core monorepo #1551Changelog
N/A
Checklist