Skip to content

eth-json-rpc-provider migration - B2: Replace typescript, jest config files. - #1765

Merged
MajorLift merged 13 commits into
mainfrom
231003-migrate-eth-json-rpc-provider-b2
Oct 5, 2023
Merged

eth-json-rpc-provider migration - B2: Replace typescript, jest config files.#1765
MajorLift merged 13 commits into
mainfrom
231003-migrate-eth-json-rpc-provider-b2

Conversation

@MajorLift

@MajorLiftMajorLift commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

Explanation

This PR implements the following incremental step in the process for migrating eth-json-rpc-provider into the core monorepo:


Phase B: Staging in migrated-packages/

2. Replace config files.

  • Update tsconfig*.json, typedoc.json, jest.config.js to extend from corresponding files in root. Copy contents of corresponding files in other non-root packages.
  • Keep TypeScript compiler flags.
  • Add tsconfig reference paths for non-root packages that are upstream dependencies of the migration target.
  • Keep Jest coverage threshold values.
  • Add deepmerge as a devDependency.

See #1551 (comment) for an outline of the entire process.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift
MajorLift requested a review from a team as a code ownerOctober 3, 2023 20:31
@MajorLiftMajorLift self-assigned this Oct 3, 2023
@MajorLiftMajorLift added enhancement New feature or request team-wallet-framework Deprecated: Please use `team-core-platform` instead. labels Oct 3, 2023
mcmire
mcmire previously approved these changes Oct 5, 2023

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MajorLift
MajorLift requested a review from mcmireOctober 5, 2023 20:47
Comment threadmerged-packages/eth-json-rpc-provider/package.json Outdated
Comment threadmerged-packages/eth-json-rpc-provider/package.json Outdated
@MajorLift
MajorLift requested a review from mcmireOctober 5, 2023 21:02
@MajorLift
MajorLift merged commit 5e1044c into mainOct 5, 2023
@MajorLift
MajorLift deleted the 231003-migrate-eth-json-rpc-provider-b2 branch October 5, 2023 21:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or requestteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MajorLift@mcmire