Uh oh!
There was an error while loading. Please reload this page.
eth-json-rpc-provider migration - D: Repair breaking packages and finalize merge - #1770
Closed
MajorLift wants to merge 0 commit into
Conversation
MajorLift
marked this pull request as draft
October 4, 2023 00:52
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
MajorLift
changed the base branch from
main
to
230927-integrate-eth-json-rpc-providerOctober 4, 2023 00:54
eth-json-rpc-provider migration - D: Repair breaking packages and merge into core repoeth-json-rpc-provider migration - D: Repair breaking packages and finalize mergeMajorLiftforce-pushed
the
231002-resolve-downstream-errors-for-eth-json-rpc-provider-migration
branch
4 times, most recently
from
October 5, 2023 16:08
6b99e07 to
649175dCompareMajorLift
commented
Oct 11, 2023
ContributorAuthor
Consolidating into #1738 |
MajorLift
deleted the
231002-resolve-downstream-errors-for-eth-json-rpc-provider-migration
branch
October 12, 2023 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements the following incremental step in the process for migrating
eth-json-rpc-providerinto the core monorepo:Phase D: Repair and merge
1. Repair breaking code in downstream packages
network-controllerselected-network-controllertransaction-controllergas-fee-controller2. Finalize merge
packages/[package-name]directory into core main branch.See #1551 (comment) for an outline of the entire process.
References
@metamask/eth-json-rpc-providerto core monorepo #1685eth-json-rpc-providerinto core monorepo #1551@metamask/{eth-json-rpc-provider,rpc-errors}#1653Changelog
@metamask/eth-json-rpc-providerChecklist