Skip to content

Update @metamask/json-rpc-engine README to reflect migration into monorepo subpackage - #1990

Merged
MajorLift merged 2 commits into
mainfrom
231106-update-readme-json-rpc-engine
Nov 7, 2023
Merged

Update @metamask/json-rpc-engine README to reflect migration into monorepo subpackage#1990
MajorLift merged 2 commits into
mainfrom
231106-update-readme-json-rpc-engine

Conversation

@MajorLift

Copy link
Copy Markdown
Contributor

Explanation

Adds an "Installation" and "Contributing" section to the @metamask/json-rpc-engine README, as it has been migrated into the monorepo.

In future migrations, this step will be performed in "Phase B" (see #1551 (comment)), while the package is being staged in the merged-packages/ temporary directory.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLiftMajorLift added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Nov 7, 2023
@MajorLiftMajorLift self-assigned this Nov 7, 2023
@MajorLift
MajorLift requested a review from a team as a code ownerNovember 7, 2023 02:09

@mikespositomikesposito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift
MajorLift merged commit 9342a1a into mainNov 7, 2023
@MajorLift
MajorLift deleted the 231106-update-readme-json-rpc-engine branch November 7, 2023 15:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MajorLift@mikesposito