Skip to content

Release 89.0.0 - #2004

Merged
BelfordZ merged 8 commits into
mainfrom
release/89.0.0
Nov 7, 2023
Merged

Release 89.0.0#2004
BelfordZ merged 8 commits into
mainfrom
release/89.0.0

Conversation

@BelfordZ

@BelfordZBelfordZ commented Nov 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation

Release queued request controller with fixes for network nickname & addEthereumChain

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ
BelfordZ requested a review from a team as a code ownerNovember 7, 2023 20:33
adonesky1
adonesky1 reviewed Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
adonesky1
adonesky1 reviewed Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
adonesky1
adonesky1 reviewed Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
BelfordZ
BelfordZ commented Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
BelfordZ
BelfordZ commented Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
adonesky1
adonesky1 reviewed Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
BelfordZ
BelfordZ commented Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
adonesky1
adonesky1 previously approved these changes Nov 7, 2023
View reviewed changes

@adonesky1adonesky1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jiexi
jiexi reviewed Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
@BelfordZ@jiexi
fix typo on changelog
afbc3f5
Co-authored-by: jiexi <jiexiluan@gmail.com>
jiexi
jiexi previously approved these changes Nov 7, 2023
View reviewed changes
mcmire
mcmire reviewed Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
- Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957))

### Fixed
- Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000))

@mcmiremcmireNov 7, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about nicknames got fixed? Is it that they're now available, and if so, available how? Also, it's not just nickname but theoretically any other network configuration information yes? It would be nice to be more clear here for other consumers.

Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated

### Fixed
- Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000))
- Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000))

@mcmiremcmireNov 7, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that it did show it before and does not now, or the opposite? It would be nice to be more clear here for other consumers.

BelfordZ
BelfordZ commented Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
BelfordZ
BelfordZ commented Nov 7, 2023
View reviewed changes
Comment threadpackages/queued-request-controller/CHANGELOG.md Outdated
@BelfordZ
BelfordZ requested a review from mcmireNovember 7, 2023 21:26
@mcmiremcmire mentioned this pull request Nov 7, 2023
Merged
6 tasks
mcmire
mcmire approved these changes Nov 7, 2023
View reviewed changes

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@BelfordZ
BelfordZ merged commit 7c74b62 into mainNov 7, 2023
@BelfordZ
BelfordZ deleted the release/89.0.0 branch November 7, 2023 21:43
MajorLift added a commit that referenced this pull request Nov 7, 2023
@MajorLift
Remove redundant CHANGELOG entry (added in#2004)
6a5f2f3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmiremcmiremcmire approved these changes
@adonesky1adonesky1adonesky1 approved these changes
@jiexijiexiAwaiting requested review from jiexi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BelfordZ@mcmire@jiexi@adonesky1