Skip to content

Remove Shapeshift controller - #209

Merged
rekmarks merged 1 commit into
developfrom
delete-shapeshift
Feb 27, 2020
Merged

Remove Shapeshift controller#209
rekmarks merged 1 commit into
developfrom
delete-shapeshift

Conversation

@rekmarks

Copy link
Copy Markdown
Member

The Shapeshift controller was recently removed from the extension, and is slated for removal from mobile. This removes it from Gaba as well.

Comment thread.gitignore Outdated
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #209 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #209 +/- ##
======================================
Coverage 100% 100% ======================================
Files 23 22 -1 Lines 1520 1488 -32 Branches 211 206 -5 ======================================
- Hits 1520 1488 -32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17d911...d67fa91. Read the comment docs.

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrhwhymarrh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks
rekmarks merged commit 3bbf5ad into developFeb 27, 2020
@whymarrh
whymarrh deleted the delete-shapeshift branch February 27, 2020 15:25
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
`@metamask/network-controller` now contains an `RpcService` class. Using
this class not only allows us to remove a lot of code from this package,
as it incorporates the vast majority of logic contained in
`createFetchMiddleware`, including the retry logic, but it also allows
us to use the circuit breaker pattern and the exponential backoff
pattern to prevent too many retries if the network is unreliable, and
then automatically cut over to a failover node when the network truly
goes down.
Closes#356.
Closes#207.
Closes#209.
Closes#211.
Closes#166.
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
…Mask#209)
Bumps [@metamask/base-controller](https://github.com/MetaMask/core) from 3.2.2 to 3.2.3.
- [Release notes](https://github.com/MetaMask/core/releases)
- [Commits](https://github.com/MetaMask/core/compare/@metamask/base-controller@3.2.2...@metamask/base-controller@3.2.3)
---
updated-dependencies:
- dependency-name: "@metamask/base-controller"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rekmarks@codecov-io@whymarrh@Gudahtt