Skip to content

Poll GitHub for phishing config file - #229

Merged
whymarrh merged 1 commit into
MetaMask:1.xfrom
whymarrh:blacklist-endpoint
May 7, 2020
Merged

Poll GitHub for phishing config file#229
whymarrh merged 1 commit into
MetaMask:1.xfrom
whymarrh:blacklist-endpoint

Conversation

@whymarrh

@whymarrhwhymarrh commented May 7, 2020

Copy link
Copy Markdown
Contributor

Refs #219

This PR removes the usage of the https://api.infura.io/v2/blacklist endpoint, replacing it with fetching the config from GitHub directly.

@whymarrh
whymarrhforce-pushed the blacklist-endpoint branch from 2460b2a to bf20ebaCompareMay 7, 2020 18:37
@whymarrh
whymarrhforce-pushed the blacklist-endpoint branch from bf20eba to 4bb3bbdCompareMay 7, 2020 18:45
@whymarrh
whymarrh marked this pull request as ready for review May 7, 2020 18:48
@whymarrh
whymarrh requested a review from a teamMay 7, 2020 18:48
@whymarrh

whymarrh commented May 7, 2020

Copy link
Copy Markdown
ContributorAuthor

This is the 1.x branch, ignore the CircleCI error as this branch is pre-CircleCI config.

@whymarrh

whymarrh commented May 7, 2020

Copy link
Copy Markdown
ContributorAuthor

I'm going to create a similar fix for develop and cut a 2.x release.

@whymarrh

whymarrh commented May 7, 2020

Copy link
Copy Markdown
ContributorAuthor

I've tested this change with the extension and it works as expected

Gudahtt
Gudahtt approved these changes May 7, 2020
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrhwhymarrh mentioned this pull request May 7, 2020
Merged
@whymarrh
whymarrh merged commit 55408d5 into MetaMask:1.xMay 7, 2020
@whymarrh
whymarrh deleted the blacklist-endpoint branch May 7, 2020 19:38
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
@dependabot
chore(deps): bump @metamask/network-controller from 15.1.0 to 15.2.0 (M…
79dec12
…etaMask#229)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GudahttGudahttGudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whymarrh@Gudahtt