Uh oh!
There was an error while loading. Please reload this page.
Make sure accounts is always an Array - #26
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #26 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 18 18 Lines 889 889 Branches 97 97 =====================================
Hits 889 889Continue to review full report at Codecov.
|
bitpshr
approved these changes
Nov 19, 2018
bitpshr
left a comment
Contributor
There was a problem hiding this comment.
One stylistic comment, but this shouldn't hold up the PR. Looks good.
Uh oh!
There was an error while loading. Please reload this page.
mcmire added a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Published versions of `superstruct` between 0.16.1 and 0.16.4 contained syntax (`??=`) that Node did not support until v15. This effectively changed the minimum required Node version for this package, and any other package using this package, to v15. A [fix for this issue][1] landed in `superstruct` 0.16.5, so this commit bumps that library accordingly so as to restore compatibility with Node 14. [1]: ianstormtaylor/superstruct#1112
kanthesha pushed a commit
that referenced
this pull request
Sep 19, 2023
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.2 to 6.12.6. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.12.2...v6.12.6) --- updated-dependencies: - dependency-name: ajv dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit
that referenced
this pull request
Sep 22, 2023
kanthesha pushed a commit
that referenced
this pull request
Oct 11, 2023
Mrtenz pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
* 1.2.0 * clean up changelog for 1.2.0 Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Matthew Epps <mepps32@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing
keyring.getAccounts().mapbut when you're starting from scratch there's no keyring and undefined.map() breaks.