Uh oh!
There was an error while loading. Please reload this page.
Use shared ESLint config - #265
Merged
Merged
Conversation
whymarrhforce-pushed
the
shared-eslint-config
branch
3 times, most recently
from
September 7, 2020 18:46
6b876e7 to
3fd11ebComparewhymarrhforce-pushed
the
shared-eslint-config
branch
from
September 8, 2020 17:17
3fd11eb to
2000f64Comparewhymarrh
marked this pull request as ready for review
September 8, 2020 17:19
Gudahtt
approved these changes
Sep 9, 2020
| @@ -1,10 +1,13 @@ | |||
| import BaseController, { BaseConfig, BaseState } from '../BaseController'; | |||
| // TODO: Destructuring this line introduces a compilation error | |||
ContributorAuthor
There was a problem hiding this comment.
I guess TypeScript doesn't notice it until it's destructured—the BN type is used in a public-facing type but isn't exported itself, which makes it hard (impossible in some cases) for consumers of the package to get the types to work. This doesn't affect us right now since we don't use these types anywhere.
Mrtenz pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
…taMask#265) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#242
This PR migrates the project to the shared ESLint config.
Tip:Ignore white space in code review
I've disabled a lot of rules to get everything passing—a few to have Prettier and ESLint play nicely together, a lot more because of how the tests & sources are currently written. We can enable them one-by-one in future PRs.