Skip to content

Mark initial state and config as readonly - #271

Merged
whymarrh merged 1 commit into
developfrom
readonly-initial
Sep 10, 2020
Merged

Mark initial state and config as readonly#271
whymarrh merged 1 commit into
developfrom
readonly-initial

Conversation

@whymarrh

@whymarrhwhymarrh commented Sep 10, 2020

Copy link
Copy Markdown
Contributor

The initialState and initialConfig properties are only assigned in the constructor so they can be marked as readonly.

@whymarrh
whymarrh requested a review from a team as a code ownerSeptember 10, 2020 19:24
@whymarrhwhymarrh changed the title Mark inital state and config as readonlyMark initial state and config as readonlySep 10, 2020
estebanmino
estebanmino approved these changes Sep 10, 2020
View reviewed changes

@estebanminoestebanmino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

rekmarks
rekmarks approved these changes Sep 10, 2020
View reviewed changes

@rekmarksrekmarks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sense-making detected.

@whymarrh
whymarrh merged commit 1bf8a15 into developSep 10, 2020
@whymarrh
whymarrh deleted the readonly-initial branch September 10, 2020 20:07
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@dependabot
Bump @metamask/json-rpc-engine from 7.2.0 to 7.3.0 (#271)
bfe53e7
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
@dan437
Add support for more transactions, emit events (MetaMask#271)
f4314f0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rekmarksrekmarksrekmarks approved these changes
+1 more reviewer
@estebanminoestebanminoestebanmino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@whymarrh@estebanmino@rekmarks