Skip to content

Remove If-None-Match header from phishing config requests#277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whymarrh merged 1 commit into from
Sep 15, 2020
Merged

Remove If-None-Match header from phishing config requests #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/third-party/PhishingController.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,8 +54,6 @@ export interface PhishingState extends BaseState {
export class PhishingController extends BaseController<PhishingConfig, PhishingState> {
private configUrl = 'https://cdn.jsdelivr.net/gh/MetaMask/eth-phishing-detect@master/src/config.json';

private configEtag = '';

private detector: any;

private handle?: NodeJS.Timer;
Expand DownExpand Up@@ -141,15 +139,10 @@ export class PhishingController extends BaseController<PhishingConfig, PhishingS
}

private async queryConfig(input: RequestInfo): Promise<EthPhishingResponse | null> {
const response = await fetch(input, {
headers: {
'If-None-Match': this.configEtag,
},
});
const response = await fetch(input);

switch (response.status) {
case 200: {
this.configEtag = response.headers.get('ETag') || /* istanbul ignore next */ '';
return await response.json();
}
case 304:
Expand Down