Skip to content

Delete network status controller - #298

Merged
rekmarks merged 1 commit into
developfrom
delete-network-status-controller
Nov 9, 2020
Merged

Delete network status controller#298
rekmarks merged 1 commit into
developfrom
delete-network-status-controller

Conversation

@rekmarks

@rekmarksrekmarks commented Nov 9, 2020

Copy link
Copy Markdown
Member

Deletes the network status controller and removes all references thereto.

@rekmarks
rekmarks requested a review from a team as a code ownerNovember 9, 2020 16:23
@estebanminoestebanmino mentioned this pull request Nov 9, 2020
Merged
3 tasks
danjm
danjm approved these changes Nov 9, 2020
View reviewed changes

@danjmdanjm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gudahtt
Gudahtt approved these changes Nov 9, 2020
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks

rekmarks commented Nov 9, 2020

Copy link
Copy Markdown
MemberAuthor

I don't know why it keeps doing this, but the status checks aren't happening even though the pipeline is passing: https://app.circleci.com/pipelines/github/MetaMask/controllers?branch=delete-network-status-controller

@rekmarks
rekmarks merged commit cba7aa1 into developNov 9, 2020
@rekmarks
rekmarks deleted the delete-network-status-controller branch November 9, 2020 17:01
@rekmarksrekmarks mentioned this pull request Nov 9, 2020
Merged
@GudahttGudahtt mentioned this pull request Nov 4, 2021
Closed
Mrtenz added a commit that referenced this pull request Oct 16, 2025
@github-actions@Mrtenz
11.0.4 (#298)
e62ae68
This is the release candidate for version 11.0.4.
---------
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
@dan437
Emit an event after a tx is confirmed, remove "skipConfirm", return "…
dd2ea3e
…txHash" (MetaMask#298)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GudahttGudahttGudahtt approved these changes
+1 more reviewer
@danjmdanjmdanjm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekmarks@Gudahtt@danjm