Uh oh!
There was an error while loading. Please reload this page.
Release 104.0.0 - #3695
Merged
Merged
Conversation
Gudahttforce-pushed
the
release/104.0.0
branch
from
December 21, 2023 20:34
6e86ed0 to
6f53e7bCompareUpdated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Gudahttforce-pushed
the
release/104.0.0
branch
from
December 21, 2023 22:11
8b18117 to
c04462fCompareGudahtt
marked this pull request as ready for review
December 21, 2023 22:15
This was accidentally set to major at first because the breaking change to the ComposableController appeared in the auto-generated changelog.
Gudahttforce-pushed
the
release/104.0.0
branch
from
December 21, 2023 22:23
f5a7d81 to
d68cb28Comparemcmire
reviewed
Dec 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
3 tasks
* origin/main: Upgrade `TokenDetectionController` to extend `BaseControllerV2`, `StaticIntervalPollingController` (#3609)
* origin/main: Recategorize controller dependencies as devDependencies if only imports are messaging system-related types (#3607)
I've updated some of the changelogs to simplify them (no need to explain `devDependency` changes, those aren't public) and to clarify that the one peer dependency addition is breaking.
Gudahtt added a commit
that referenced
this pull request
Dec 22, 2023
## Explanation The `subscribe` property was removed in #3590 because it is no longer used. It has been restored here so that we can release the `@metamask/base-controller` without any breaking changes. This property's description has been updated to clarify that it's no longer used, and it's now marked as deprecated. ## References Discussed in the v104 release candidate PR: #3695 (comment) ## Changelog ### `@metamask/base-controller` - Changed: Deprecate the `subscribe` property of `BaseControllerV2` - This property was used to differentiate between `BaseControllerV1` and `BaseControllerV2` controllers. It is no longer used, so it has been marked as deprecated. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
* origin/main: chore(base-controller): Restore `subscrbe` property (#3698)
Gudahtt
commented
Dec 22, 2023
MemberAuthor
This is now ready for review again, the changelogs have been updated for all three recently merged PRs. |
Mrtenz
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
See changelogs