Skip to content

Release/110.0.0 - #3810

Merged
montelaidev merged 16 commits into
mainfrom
release/110.0.0
Jan 23, 2024
Merged

Release/110.0.0#3810
montelaidev merged 16 commits into
mainfrom
release/110.0.0

Conversation

@montelaidev

@montelaidevmontelaidev commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Release the following packages:

@metamask/keyring-controller@12.1.0
@metamask/accounts-controller@9.0.0
@metamask/signature-controller@11.0.0

Confirmed there are no dependencies on unreleased code.

@montelaidev
montelaidev requested a review from a team as a code ownerJanuary 22, 2024 15:15
@socket-security

socket-securityBot commented Jan 22, 2024

Copy link
Copy Markdown

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

@legobeat

legobeat commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Some peerDeps need to be aligned (or exempted?):

➤ YN0024: @metamask/accounts-controller must depend on @metamask/keyring-controller via ^13.0.0, but uses ^12.0.0 instead (in dependencies)
➤ YN0053: @metamask/accounts-controller must depend on @metamask/keyring-controller via conflicting ranges ^13.0.0 and ^12.0.0 (in peerDependencies)
➤ YN0024: @metamask/signature-controller must depend on @metamask/keyring-controller via ^13.0.0, but uses ^12.0.0 instead (in dependencies)
➤ YN0053: @metamask/signature-controller must depend on @metamask/keyring-controller via conflicting ranges ^13.0.0 and ^12.0.0 (in peerDependencies)
➤ YN0000: Failed with errors in 3s 707ms
Error: Process completed with exit code 1.

https://github.com/MetaMask/core/actions/runs/7613357335/job/20733092582?pr=3810

Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
@montelaidev

Copy link
Copy Markdown
ContributorAuthor

Performed a force push, to align the peer dependencies.

Comment threadpackages/accounts-controller/CHANGELOG.md Outdated
Comment threadpackages/accounts-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
@montelaidevmontelaidev changed the title Release/110.0.0Release/109.1.0Jan 22, 2024
Comment threadpackages/signature-controller/CHANGELOG.md Outdated
@montelaidevmontelaidev changed the title Release/109.1.0Release/11.0.0Jan 23, 2024
@legobeatlegobeat changed the title Release/11.0.0Release/110.0.0Jan 23, 2024
Comment threadpackages/accounts-controller/CHANGELOG.md Outdated
Comment threadpackages/signature-controller/CHANGELOG.md Outdated
Gudahtt
Gudahtt previously approved these changes Jan 23, 2024

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Gudahtt dismissed their stale reviewJanuary 23, 2024 14:12

Recinding approval until #3820 is merged

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@montelaidev
montelaidev merged commit 007648b into mainJan 23, 2024
@montelaidev
montelaidev deleted the release/110.0.0 branch January 23, 2024 14:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@montelaidev@legobeat@Gudahtt@gantunesr@AlexJupiter