[token-detection-controller] Add tests for API changes from merge with DetectTokensController

[MajorLift]

Explanation

• This PR adds unit tests for the token-detection-controller API changes implemented in [token-detection-controller] Consolidate with DetectTokensController from extension #3775.
• The following changes are covered in the new tests:
  • Don't detect if keyring-controller isUnlocked state is false.
  • Subscribe to KeyringController:unlock, KeyringController:lock events
  • Subscribe to AccountsController:selectedAccountChange event
  • Detect tokens using @metamask/contract-metadata static token list if on mainnet and useTokenDetection is false.
  • Call trackMetaMetricsEvent for every detected token.
• The aim of this PR isn't to achieve 100% test coverage for token-detection-controller. That will be the goal of follow-up ticket TokenDetectionController: Write comprehensive unit tests #1615

References

• ClosesMerge extension DetectTokensController into core TokenDetectionController #3626
• Follows from:
  • [token-detection-controller] Consolidate with DetectTokensController from extension #3775
  • [assets-controllers] Upgrade TokensController to fully utilize controller-messenger pattern #3690
• Followed by TokenDetectionController: Write comprehensive unit tests #1615

Changelog

N/A

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[mcmire]

I'll wait until the parent PR is merged before giving final approval on this PR.

[mcmire]

Aside from the nitpicks I had one question.

[mcmire]

Nit: false is a boolean, not a string:

Suggested change

	describe('when "disabled" is "false"',()=>{
	describe('when "disabled" is false',()=>{

[MajorLift]

Fixed throughout test file: ad3593d

[mcmire]

Similar as previous nit:

Suggested change

	describe('when "disabled" is "true"',()=>{
	describe('when "disabled" is true',()=>{

[MajorLift]

Same as above: ad3593d

[mcmire]

I'm curious if adding a new option here could confuse people reading the tests into thinking that the controller takes this option. For other test files I've been purposely limiting options to just whatever options the controller takes for this reason. Should isKeyringUnlocked be a separate option in WithControllerOptions?

[MajorLift]

I wasn't sure where to put isKeyringUnlocked, but I like the idea of keeping options limited to controller constructor.

Applied here: 95b34ac

[mcmire]

LGTM!