Uh oh!
There was an error while loading. Please reload this page.
Release/118.0.0 - #3958
Conversation
b720757 to
18c2badCompare723d0a5 to
fc90b6fCompareUh oh!
There was an error while loading. Please reload this page.
fc90b6f to
a485424CompareCo-authored-by: jiexi <jiexiluan@gmail.com>
mcmire
left a comment
There was a problem hiding this comment.
One nit but looks good either way! Great changelog entries.
Uh oh!
There was an error while loading. Please reload this page.
jiexi
left a comment
There was a problem hiding this comment.
QueuedRequestController also needs to be bumped a major
Uh oh!
There was an error while loading. Please reload this page.
| - **BREAKING:** `setNetworkClientIdForDomain` now throws an error if passed `metamask` for the domain param ([#3908](https://github.com/MetaMask/core/pull/3908)). | ||
| - **BREAKING:** `setNetworkClientIdForDomain` now includes a check that the requesting `domain` has already been granted permissions in the `PermissionsController` before adding it to `domains` state and throws an error if the domain does not have permissions ([#3908](https://github.com/MetaMask/core/pull/3908)). | ||
| - **BREAKING:** the `domains` state now no longer contains a `metamask` domain key Consumers should instead use the `selectedNetworkClientId` from the `NetworkController` to get the selected network for the `metamask` domain ([#3908](https://github.com/MetaMask/core/pull/3908)). |
There was a problem hiding this comment.
This in implementation detail heavy. To the end user, getNetworkClientIdForDomain will still passthrough the selectedNetworkClientId, so nothing should be different for the consumer? Do we have consumers accessing SelectedNetworkController state directly?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: jiexi <jiexiluan@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
`@metamask/queued-request-controller` was bumped to 0.5.0 in [release 118.0](#3958), but changes that took place since 0.4.0 were not included in the changelog for that release. This commit corrects this.
@metamask/selected-network-controller
[8.0.0]
Changed
setNetworkClientIdForDomainnow throws an error if passedmetamaskas its first (domain) argument (#3908).setNetworkClientIdForDomainnow includes a check that the requestingdomainhas already been granted permissions in thePermissionsControllerbefore adding it todomainsstate and throws an error if the domain does not have permissions (#3908).domainsstate now no longer contains ametamaskdomain key Consumers should instead use theselectedNetworkClientIdfrom theNetworkControllerto get the selected network for themetamaskdomain (#3908).getProviderAndBlockTrackernow throws an error if called with any domain while theperDomainNetworkflag is false. Consumers should instead use theproviderandblockTrackerfrom theNetworkControllerwhen theperDomainNetworkflag is false (#3908).getProviderAndBlockTrackernow throws an error if called with a domain that is not in domains state (#3908).getNetworkClientIdForDomainnow returns theselectedNetworkClientIdfor the globally selected network if theperDomainNetworkflag is false and if the domain is not in thedomainsstate (#3908).Removed
selectedNetworkMiddlewareto set a defaultnetworkClientIdfor the requesting origin when not already set. Now if nonetworkClientIdis already set for the requesting origin, the middleware will not add the origin todomainsstate but will add thenetworkClientIdcurrently set for theselectedNetworkClientfrom theNetworkControllerto the request object (#3908).Fixed
SelectedNetworkControllernow listens fornetworkConfigurationremoval events on theNetworkControllerand if a removednetworkClientIdmatches the setnetworkClientIdfor any domains in its state, it updates them to the globally selectednetworkClientIdand repoints the proxies accordingly.(#3926)