Skip to content

Release 123.0.0 - #3997

Closed
mikesposito wants to merge 3 commits into
mainfrom
release/123.0.0
Closed

Release 123.0.0#3997
mikesposito wants to merge 3 commits into
mainfrom
release/123.0.0

Conversation

@mikesposito

@mikespositomikesposito commented Feb 29, 2024

Copy link
Copy Markdown
Member

This is a release PR for the following packages:

  • @metamask/keyring-controller
  • @metamask/preferences-controller
  • @metamask/assets-controller
  • @metamask/accounts-controller
  • @metamask/user-operation-controller
  • @metamask/signature-controller
  • @metamask/transaction-controller

@mikesposito
mikesposito changed the base branch from main to release/122.0.0February 29, 2024 12:26
Base automatically changed from release/122.0.0 to mainFebruary 29, 2024 20:53
@mikesposito
mikesposito marked this pull request as ready for review March 1, 2024 12:07
@mikesposito
mikesposito requested a review from a team as a code ownerMarch 1, 2024 12:07
@mcmire

mcmire commented Mar 1, 2024

Copy link
Copy Markdown
Collaborator

I spoke with @mikesposito today and he said that because we already had an existing release branch open, he didn't use create-release-branch to create this PR but rather created it manually. With the other release PR merged, I was able to run it, however. It revealed that due to dependencies / peer dependencies, we may also need to release the following packages:

  • @metamask/base-controller
  • @metamask/approval-controller
  • @metamask/controller-utils
  • @metamask/gas-fee-controller
  • @metamask/logging-controller
  • @metamask/message-manager
  • @metamask/network-controller
  • @metamask/polling-controller

We would need to check over these to see if there are any we could reasonably omit or any that we should include.

I will try to recreate this PR today with new updates. If I don't have time for it though, then we should try to see if we can do this on Monday.

@mcmiremcmire mentioned this pull request Mar 1, 2024
@mcmire

Copy link
Copy Markdown
Collaborator

Okay, I've created #4007 which supercedes this one. It includes the packages listed here as well as the ones I mentioned above (minus @metamask/base-controller, which is safe to ignore). I will mark this PR as DO-NOT-MERGE so it's still visible.

@mikesposito

Copy link
Copy Markdown
MemberAuthor

@mcmire Thanks for checking! I'll close this one then

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mikesposito@mcmire@matthewwalsh0