Uh oh!
There was an error while loading. Please reload this page.
deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.4 - #4190
deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.4#4190legobeat wants to merge 1 commit into
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
4d962ac to
346de6aComparelegobeat
commented
Apr 18, 2024
network access ok |
3736bba to
39a92d8Compare2599375 to
0d8cd21Compare0d8cd21 to
4c668bfCompare…let@^2.0.4 - fix: wallet privatekey import fix - fix: catch and throw error previously handled by ethereumjs-wallet
4c668bf to
f3788d0Comparelegobeat
commented
Dec 24, 2024
@MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers: I believe |
Explanation
Removes dependency on legacy and deprecated
ethereumjs-wallet.References
Related
Blocked by
Changelog
@metamask/keyring-controllerethereumjs-wallet@^1.0.1to@ethereumjs/wallet@^2.0.4Checklist