Skip to content

deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.4 - #4190

Open
legobeat wants to merge 1 commit into
MetaMask:mainfrom
legobeat:deps-ethereumjs-wallet-2
Open

deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.4#4190
legobeat wants to merge 1 commit into
MetaMask:mainfrom
legobeat:deps-ethereumjs-wallet-2

Conversation

@legobeat

@legobeatlegobeat commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Explanation

Removes dependency on legacy and deprecated ethereumjs-wallet.

References

Related

Blocked by

Changelog

@metamask/keyring-controller

  • CHANGED: Update from ethereumjs-wallet@^1.0.1 to @ethereumjs/wallet@^2.0.4

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security

socket-securityBot commented Apr 18, 2024

Copy link
Copy Markdown

New dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@ethereumjs/wallet@2.0.4Transitive: network+31.11 MBholgerd77

View full report↗︎

@socket-security

socket-securityBot commented Apr 18, 2024

Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

AlertPackageNoteSourceCI
Network access npm/@ethereumjs/util@9.1.0 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@ethereumjs/util@9.1.0

@legobeatlegobeat added dependencies Pull requests that update a dependency file team-security labels Apr 18, 2024
@legobeat
legobeatforce-pushed the deps-ethereumjs-wallet-2 branch from 4d962ac to 346de6aCompareApril 18, 2024 23:37
@legobeat

Copy link
Copy Markdown
ContributorAuthor
@SocketSecurity ignore npm/@ethereumjs/util@9.0.3

network access ok

@legobeat
legobeatforce-pushed the deps-ethereumjs-wallet-2 branch 2 times, most recently from 3736bba to 39a92d8CompareApril 25, 2024 18:51
@legobeat
legobeatforce-pushed the deps-ethereumjs-wallet-2 branch 3 times, most recently from 2599375 to 0d8cd21CompareJune 10, 2024 17:23
@legobeat
legobeatforce-pushed the deps-ethereumjs-wallet-2 branch from 0d8cd21 to 4c668bfCompareDecember 23, 2024 23:38
@legobeatlegobeat changed the title deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.3deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.4Dec 23, 2024
@legobeat
legobeat marked this pull request as ready for review December 23, 2024 23:41
@legobeat
legobeat requested review from a team as code ownersDecember 23, 2024 23:41
…let@^2.0.4
- fix: wallet privatekey import fix
- fix: catch and throw error previously handled by ethereumjs-wallet
@legobeat

Copy link
Copy Markdown
ContributorAuthor

@MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers: I believe DO-NOT-MERGE label can be removed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency fileDO-NOT-MERGEteam-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@legobeat