Uh oh!
There was an error while loading. Please reload this page.
refactor: update Nft Controllers to use selectedAccountId instead of selectedAddress - #4221
Conversation
montelaidev
commented
Apr 26, 2024
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
61ace68 to
dd6e3e8Comparedd6e3e8 to
42bbf96CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| constructor({ | ||
| chainId: initialChainId, | ||
| selectedAddress = '', | ||
| selectedAccountId = '', |
There was a problem hiding this comment.
Similar comment as here — what are your thoughts on using the messenger to get this value from the AccountsController a bit later on in this constructor instead of having the constructor take this argument?
…controllers-to-use-internal-account
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Explanation
This PR updates removes
selectedAddressand uses the controller messenger to get InternalAccounts in the Nft ControllersReferences
Fixeshttps://github.com/MetaMask/accounts-planning/issues/381
Changelog
@metamask/assets-controllersNftControllerconstructor argumentselectedAddresshas been removed.NftControllernow requiresAccountsControlelr:get{Account,SelectedAccount}messenger actions.NftControllernow requiresAccountsController:selectedEvmAccountChangeevent.NftDetectionControllernow requiresAccountsControlelr:getSelectedAccountmessenger actions.Checklist