Uh oh!
There was an error while loading. Please reload this page.
deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0 - #4327
Closed
legobeat wants to merge 4 commits into
Closed
deps(transaction-controller): @metamask/nonce-tracker@^5.0.0->^6.0.0#4327legobeat wants to merge 4 commits into
legobeat wants to merge 4 commits into
Conversation
legobeatforce-pushed
the
deps-nonce-tracker-6
branch
5 times, most recently
from
May 30, 2024 23:10
0d0f46c to
3d59210Compare7 tasks
legobeatforce-pushed
the
deps-nonce-tracker-6
branch
2 times, most recently
from
June 6, 2024 22:32
caa09ab to
2d19826Compare
This was referenced Jun 6, 2024
legobeatforce-pushed
the
deps-nonce-tracker-6
branch
2 times, most recently
from
June 8, 2024 00:50
31bf8ca to
5a7b861Comparelegobeat
marked this pull request as ready for review
June 8, 2024 00:56
legobeatforce-pushed
the
deps-nonce-tracker-6
branch
from
June 10, 2024 00:23
5a7b861 to
962fc13Comparelegobeatforce-pushed
the
deps-nonce-tracker-6
branch
from
June 10, 2024 09:27
962fc13 to
c807342Comparelegobeatforce-pushed
the
deps-nonce-tracker-6
branch
from
June 10, 2024 17:44
c807342 to
d4c8478Comparelegobeat
commented
Jun 10, 2024
ContributorAuthor
@metamaskbot publish-preview |
legobeatforce-pushed
the
deps-nonce-tracker-6
branch
from
June 10, 2024 18:06
d4c8478 to
0f65e9eCompare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
legobeat
commented
Jun 10, 2024
ContributorAuthor
Prerelease builds:
|
kumavis
previously approved these changes
Jun 11, 2024
mikesposito
previously approved these changes
Jun 11, 2024
legobeatforce-pushed
the
deps-nonce-tracker-6
branch
from
June 13, 2024 00:16
0f65e9e to
32a2f8eCompare7 tasks
3 tasks
shanejonas added a commit
that referenced
this pull request
Jun 19, 2024
## Explanation Please see https://github.com/MetaMask/MetaMask-planning/issues/2668 ## References See: https://github.com/MetaMask/MetaMask-planning/issues/2668 Unblocks: #4327 ## Changelog No user facing changes ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Derek Brans <dbrans@gmail.com>
mcmire pushed a commit
that referenced
this pull request
Jun 20, 2024
## Explanation Please see MetaMask/MetaMask-planning#2668 ## References See: MetaMask/MetaMask-planning#2668 Unblocks: #4327 ## Changelog No user facing changes ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Derek Brans <dbrans@gmail.com>
legobeat
dismissed stale reviews from mikesposito, kumavis, and mcmire
via
July 12, 2024 00:36
26820497 tasks
legobeat
commented
Aug 13, 2024
ContributorAuthor
Superseded by #4591 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Updates
@metamask/nonce-trackerto remove need for@ts-expect-erroraround theblockTrackertype.Also updatestransaction-controllertests to reset providers and block trackers between each test.!isMultichainEnabled#4390 and bug fixed in@metamask/nonce-tracker6. Merging fix(transaction-controller): Return global ethQuery when!isMultichainEnabled#4390 and testfix(transaction-controller): Refactor provider setup to provide correct providers and tracker #4391 will make tests pass here.References
!isMultichainEnabled#4390dependabot version: chore(deps): bump @metamask/nonce-tracker from 5.0.0 to 6.0.0 #4329Changelog
@metamask/network-controller@metamask/eth-block-trackerfrom^9.0.2to^9.0.3@metamask/transaction-controller@metamask/nonce-trackerfrom^5.0.0to^6.0.0Checklist