feat: add getSelectedMultichainAccount and listMultichainAccounts by montelaidev · Pull Request #4330 · MetaMask/core

montelaidev · 2024-05-28T14:08:12Z

Explanation

This pull request adds two new methods getSelectedMultichainAccount, listMultichainAccounts and selectedEvmAccountChange event. The optional arguments are to make the changes backwards compatible when used with evm specific controllers.

References

Related to:

Changelog

`@metamask/accounts-controller`

: Adds two new methods getSelectedMultichainAccount, listMultichainAccounts, and selectedEvmAccountChange event

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

…ctedEvmAccountChange event

…-to-accounts-controller

gantunesr

Can you revisit the name of the test to remove the work should? I pointed out a few but there are more from what I saw

Dismissing to unblock

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

) ## Explanation This pull request adds two new methods `getSelectedMultichainAccount`, `listMultichainAccounts` and `selectedEvmAccountChange` event. The optional arguments are to make the changes backwards compatible when used with evm specific controllers. ## References Related to: - [381](MetaMask/accounts-planning#381) - [419](MetaMask/accounts-planning#419) ## Changelog ### `@metamask/accounts-controller` - **<CHANGED>**: Adds two new methods `getSelectedMultichainAccount`, `listMultichainAccounts`, and `selectedEvmAccountChange` event ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

feat: add optional args to listAccounts, getSelectedAccount, and sele…
bb9d235
…ctedEvmAccountChange event

montelaidev requested a review from a teamMay 28, 2024 14:08

ccharly reviewed May 28, 2024
View reviewed changes

gantunesr added the team-accounts label May 29, 2024

gantunesr assigned montelaidev May 29, 2024

gantunesr previously requested changes May 29, 2024
View reviewed changes

Comment threadpackages/accounts-controller/src/AccountsController.ts Outdated
Comment threadpackages/accounts-controller/src/utils.ts Outdated

montelaidev added 5 commits May 29, 2024 22:55

Merge remote-tracking branch 'origin/main' into fix/add-optional-args…
2297c79
…-to-accounts-controller

fix: use KnownNamespace and relocate guard logic
e611a54

Merge branch 'main' into fix/add-optional-args-to-accounts-controller
2c92829

chore: add comment
b45e1b6

fix: update error message
94f3115

gantunesr reviewed May 30, 2024
View reviewed changes

Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated
Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated

montelaidev added 3 commits May 30, 2024 16:45

fix: test error message
0e4a41b

feat: add getSelectedMultichainAccount
dbac4e7

feat: add listMultichainAccounts
2974992

montelaidev changed the title ~~feat: add optional caip2 arguments to accounts controller~~feat: add getSelectedMultichainAccount and listMultichainAccountsMay 30, 2024

montelaidev added 3 commits May 30, 2024 23:03

Merge branch 'main' into fix/add-optional-args-to-accounts-controller
9b81bbe

Merge branch 'main' into fix/add-optional-args-to-accounts-controller
ff8cf4e

fix: uppercase Snap
c3c60eb

ccharly reviewed May 31, 2024
View reviewed changes

montelaidev added 3 commits May 31, 2024 16:49

fix: flip order of jsdoc args
bbe8edd

refactor: names and error message
ad329e6

refactor: getLastSelectedAccount
db08b3c

montelaidev force-pushed the fix/add-optional-args-to-accounts-controller branch from 8d35e9d to db08b3cCompare May 31, 2024 09:20

montelaidevand others added 2 commits May 31, 2024 17:23

fix: make getLastSelectedAccount private
4332b2c

Update packages/accounts-controller/src/AccountsController.test.ts
992b99f
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly reviewed May 31, 2024
View reviewed changes

refactor: test names
922e3c4

ccharly reviewed May 31, 2024
View reviewed changes

Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated

Update packages/accounts-controller/src/AccountsController.test.ts
9dacf5c
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ccharly approved these changes May 31, 2024
View reviewed changes

montelaidev merged commit a1297d7 into mainMay 31, 2024

montelaidev deleted the fix/add-optional-args-to-accounts-controller branch May 31, 2024 09:51

Uh oh!

Uh oh!

Conversation

montelaidev commented May 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Changelog

@metamask/accounts-controller

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gantunesr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

montelaidev commented May 28, 2024•
edited
Loading

`@metamask/accounts-controller`

gantunesr left a comment •
edited
Loading