Restore ESLint warnings as errors (ignoring them for now)

[mcmire]

Explanation

Currently, yarn lint produces a bunch of warnings from ESLint. These warnings were added in a previous commit that upgraded ESLint packages as a way to avoid fixing lint violations created by the upgrade. However, this causes two problems:

1. They produce a lot of noise that makes it very difficult to find true errors, especially when looking at a CI run.
2. They allow new instances of these violations to show up (because warnings don't cause eslint to fail).

This commit removes the overrides from the ESLint config for these rules so that they go back to being errors and adds eslint-disable directives above the lines that cause the violations. Note that this is not intended to be a long-term solution, and in the future, we should dedicate time to either fixing the violations or explaining why ignoring them is necessary.

References

Fixes#4381.

Changelog

(There are no changes to functionality.)

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[MajorLift]

LGTM! Hopefully the presence of these comments nudge people towards providing an explanation when disabling lint rules in general.

In future PRs, enabling the 'prefer' rules should remove the need for some style guide entries, and no-unnecessary-type-assertion should also be helpful for minimizing redundant or silent-failure assertions. I can create a PR for those if you don't already have them planned @mcmire

[mcmire]

@MajorLift I don't have plans for the changes you mention, but they sound good, so feel free to create tickets/PRs!

[rekmarks]

My terminal thanks you for this change. 🙇