Skip to content

refactor: update notification package exports - #4437

Merged
Prithpal-Sooriya merged 1 commit into
mainfrom
refactor-tidy-notification-exports
Jun 19, 2024
Merged

refactor: update notification package exports#4437
Prithpal-Sooriya merged 1 commit into
mainfrom
refactor-tidy-notification-exports

Conversation

@Prithpal-Sooriya

@Prithpal-SooriyaPrithpal-Sooriya commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Explanation

it seems we were inconsistent and forgot to correctly handle default exports and controller exports

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

it seems we were inconsistent and forgot to correctly handle default exports and controller exports
@Prithpal-SooriyaPrithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Jun 19, 2024
@Prithpal-Sooriya
Prithpal-Sooriya requested a review from a teamJune 19, 2024 12:30

@JonathansouferJonathansoufer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya
Prithpal-Sooriya merged commit d95b351 into mainJun 19, 2024
@Prithpal-Sooriya
Prithpal-Sooriya deleted the refactor-tidy-notification-exports branch June 19, 2024 12:35
mcmire pushed a commit that referenced this pull request Jun 20, 2024
## Explanation
it seems we were inconsistent and forgot to correctly handle default
exports and controller exports
## Checklist
- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-notificationsNotification Team changes. https://github.com/orgs/MetaMask/teams/notifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Prithpal-Sooriya@Jonathansoufer