Uh oh!
There was an error while loading. Please reload this page.
Adapt to eip 1193 provider changes - #4442
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
d19b2a3 to
c426abeComparecf1da22 to
4eb212cCompare4eb212c to
2b79296Compare
mikesposito
left a comment
There was a problem hiding this comment.
These changes look good!
I noticed we left unchanged FakeProvider: are we supposed to remove sendAsync from the class or any other changes related to this work?
Hi Michele, FakeProvider has already been updated in a previous PR to include the request method. I had to make this change along with the SafeEventEmitterProvider updates; otherwise, the tests would not pass. You can see the updated FakeProvider here. |
Explanation
After updating the
SafeEventEmitterProviderto support EIP-1193, I have made the following changes:sendAsyncand replaced it with therequestmethod.corerepository:NetworkControllertestssendAsyncmethod. These now use therequestmethod with the correct method signature:SelectedNetworkControllertestscreateAutoManagedNetworkClienttestsReferences
Changelog
Checklist