Skip to content

feat: add accountAdded and accountRemoved events - #4496

Merged
montelaidev merged 7 commits into
mainfrom
feat/account-added-removed-events
Jul 3, 2024
Merged

feat: add accountAdded and accountRemoved events#4496
montelaidev merged 7 commits into
mainfrom
feat/account-added-removed-events

Conversation

@montelaidev

@montelaidevmontelaidev commented Jul 3, 2024•
edited by ccharly
Loading

Copy link
Copy Markdown
Contributor

Explanation

This PR adds the following events to the AccountsController, accountAdded and accountRemoved.

References

Changelog

@metamask/accounts-controller

  • ADDED: Adds accountAdded and accountRemoved events.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidevmontelaidev self-assigned this Jul 3, 2024
@montelaidev
montelaidev requested a review from a teamJuly 3, 2024 09:09
ccharly
ccharly reviewed Jul 3, 2024
View reviewed changes
Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated
Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated
Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated
Comment threadpackages/accounts-controller/src/AccountsController.ts
Comment threadpackages/accounts-controller/src/AccountsController.ts
Comment threadpackages/accounts-controller/src/index.ts Outdated
Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated
Comment threadpackages/accounts-controller/src/AccountsController.test.ts Outdated
@ccharlyccharly changed the title feat: add accountAdded and accountRemoved eventsfeat: add accountAdded and accountRemoved eventsJul 3, 2024
montelaidevand others added 4 commits July 3, 2024 18:59
@montelaidev@ccharly
Apply suggestions from code review
a4777b7
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@montelaidev
fix: remove exports
c7c7e69
@montelaidev
fix: nit
d7bf788
@montelaidev
fix: lint
4b5c190
ccharly
ccharly approved these changes Jul 3, 2024
View reviewed changes
Comment threadpackages/accounts-controller/src/AccountsController.test.ts
@montelaidev
montelaidev merged commit 5bc1150 into mainJul 3, 2024
@montelaidev
montelaidev deleted the feat/account-added-removed-events branch July 3, 2024 13:12
@montelaidevmontelaidev mentioned this pull request Jul 3, 2024
Merged
3 tasks
ccharly added a commit that referenced this pull request Jul 3, 2024
@montelaidev@MajorLift
@mcmire@ccharly
Release/170.0.0 (#4498)
a3acb59
## Explanation
Create release for:
- `@metamask/accounts-controller` to ^17.2.0
- `@metamask/gas-fee-controller` to ^18.0.0
- `@metamask/transaction-controller` to ^34.0.0
- `@metamask/user-operation-controller` to ^13.0.0
<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:
* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->
## References
<!--
Are there any issues that this pull request is tied to? Are there other
links that reviewers should consult to understand these changes better?
For example:
* Fixes #12345
* Related to #67890
-->
## Changelog
<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.
(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)
Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).
If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.
Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->
### `@metamask/accounts-controller`
- **ADDED**: `accountAdded` and `accountRemoved` events
([#4496](#4496))
- **ADDED**: Export
`AccountsControllerListMultichainAccounts`,`AccountsControllerGetSelectedMultichainAccount`,`AccountsControllerGetNextAvailableAccountName}Action`
actions ([#4497](#4497))
- **FIXED**: Use `listMultichainAccounts` for non-EVM specific methods.
([#4494](#4494))
- **FIXED**: Set `lastSelected` for initial account
([#4494](#4494))
### `@metamask/gas-fee-controller`
- **BREAKING**: Added back the constructor options legacyAPIEndpoint and
EIP1559APIEndpoint. These URLs are no longer hardcoded within the
controller.
- **BREAKING**: Removed the infuraAPIKey. This was used to construct and
send the Authorization header for Infura gas API requests.
([#4446](#4446))
- **CHANGED**: Changing `providerConfig` to `selectedNetworkClientId`
([#4356](#4356))
- ### `@metamask/user-operation-controller`
- **BREAKING:** Bump dependency and peer dependency
`@metamask/gas-fee-controller` to `^18.0.0`
([#4498](#4498))
- **BREAKING:** Bump dependency and peer dependency
`@metamask/transaction-controller` to `^34.0.0`
([#4498](#4498))
- ### `@metamask/transaction-controller`
- **BREAKING:** Bump dependency and peer dependency
`@metamask/gas-fee-controller` to `^18.0.0`
([#4498](#4498))
## Checklist
- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
---------
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccharlyccharlyccharly approved these changes

Assignees

@montelaidevmontelaidev

Labels

team-accounts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@montelaidev@ccharly