Skip to content

Fixed SafeEventEmitterProvider invalid default params#4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kanthesha merged 2 commits into from
Aug 13, 2024
Merged

Fixed SafeEventEmitterProvider invalid default params #4603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cede9e
fixed SafeEventEmitterProvider invalid default params
kanthesha Aug 13, 2024
3d5c4e9
omit params when not passed
kanthesha Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eth-json-rpc-provider/src/safe-event-emitter-provider.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -511,7 +511,6 @@ describe('convertEip1193RequestToJsonRpcRequest', () => {
id: 'mock-id',
jsonrpc: '2.0',
method: 'test',
params: {},
});
});
});
25 changes: 13 additions & 12 deletions packages/eth-json-rpc-provider/src/safe-event-emitter-provider.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,18 +31,19 @@ export function convertEip1193RequestToJsonRpcRequest<
>(
eip1193Request: Eip1193Request<Params>,
): JsonRpcRequest<Params | Record<never, never>> {

@GudahttGudahttAug 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this return type is invalid. The Record<never, never> does not belong here, no possible return value is represented by that type. Yet if we remove it, we get the type error I referenced in the other thread. How odd.

Maybe we can fix it in a later PR, since it's a pre-existing issue. This type is used later in this file as well.

const {
id = uuidV4(),
jsonrpc = '2.0',
method,
params = {},
} = eip1193Request;
return {
id,
jsonrpc,
method,
params,
};
const { id = uuidV4(), jsonrpc = '2.0', method, params } = eip1193Request;
return params
? {
id,
jsonrpc,
method,
params,
}
: {
id,
jsonrpc,
method,
};
}

/**
Expand Down