fix: SelectedNetworkController network stateChange listener

[mikesposito]

Explanation

Currently, SelectedNetworkController subscribes to the NetworkController:stateChange event to make sure that network client ids associated with managed domains stay valid. Though, we are currently checking on the specific immer patch applied to the NetworkController state: this means that based on how the state draft was manipulated on the origin controller, we may or may not capture the change and react to it.

To fix it, now SelectedNetworkController will look at the actual content of the updated state, instead of relying on immer patches. To reduce the amount of event instances received by the controller, a selector is applied to the subscription, filtering out irrelevant instances.

References

Changelog

@metamask/network-controller

• ADDED: Added getNetworkConfigurations, getAvailableNetworkClientIds and selectAvailableNetworkClientIds selectors
  • These new selectors can be applied to messenger event subscriptions

@metamask/selected-network-controller

No consumer-faced changes

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[bergeron]

product change looks good, ive tested it via extension. Would be good to merge this to the main PR so we can publish a new preview release.

Edit: I committed it to the main PR for that reason

[mikesposito]

@bergeron sorry about that, I realized just now that this was committed to the target branch already.
I just made an additional refactor here to introduce state selectors, so that SelectedNetworkController only receives the event when it's needed: d6aca05

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/reselect@5.1.1	None	0	646 kB	acemarke

View full report↗︎

[mikesposito]

The usage of immer patches has been removed since it strictly depends on how state changes are made on the controller that originates the event.

We can reduce the number of events received by this listener using a selector