Uh oh!
There was an error while loading. Please reload this page.
Release 208.0.0 - #4731
Merged
Merged
Conversation
ccharlyforce-pushed
the
release/208.0.0
branch
from
September 25, 2024 14:44
0d6bbe0 to
e23d9feCompareccharlyforce-pushed
the
release/208.0.0
branch
from
September 25, 2024 15:15
7a31fca to
5868653Compareccharly
marked this pull request as ready for review
September 25, 2024 15:28
hmalik88
previously approved these changes
Sep 25, 2024
matthewwalsh0
approved these changes
Sep 25, 2024
Comment on lines
+15
to
+17
| - Bump accounts related packages ([#4713](https://github.com/MetaMask/core/pull/4713)), ([#4728](https://github.com/MetaMask/core/pull/4728)) | ||
| - Those packages are now built slightly differently and are part of the [accounts monorepo](https://github.com/MetaMask/accounts). | ||
| - Bump `@metamask/keyring-api` from `^8.1.0` to `^8.1.4` |
Contributor
There was a problem hiding this comment.
Suggested change
| - Bump accounts related packages ([#4713](https://github.com/MetaMask/core/pull/4713)), ([#4728](https://github.com/MetaMask/core/pull/4728)) | |
| - Those packages are now built slightly differently and are part of the [accounts monorepo](https://github.com/MetaMask/accounts). | |
| - Bump `@metamask/keyring-api` from `^8.1.0` to `^8.1.4` |
ContributorAuthor
There was a problem hiding this comment.
Yes true, but I wanted to mark those since the introduction of our new monorepo on the account side. We have done some basic testing on the extension side (using our e2e and some manual testing with preview builds) but in case there's any regression (there should not) I thought it would be great to have this being commented somewhere in the CHANGELOG.
If you think that's "too much", I'm also ok removing those!
Contributor
There was a problem hiding this comment.
Sounds perfectly reasonable to keep them. Just wanted to be sure their inclusion was intentional.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hmalik88
approved these changes
Sep 25, 2024
4 tasks
ccharly added a commit
that referenced
this pull request
Sep 25, 2024
## Explanation This reverts commit 9949c81. The `assets-controllers` version was wrong for the last RC. So we have to revert this RC and re-create it while fixing the `assets-controllers` bad version. Version during that release [was `38.0.2`](https://github.com/MetaMask/core/blob/eb656db1704c6dcfa9474086434b267b15e62c97/packages/assets-controllers/package.json#L3) but it should have been `38.1.0`. ## References - #4731 ## Changelog N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
ccharly added a commit
that referenced
this pull request
Sep 25, 2024
## Explanation This is a RC for v208.0.0. See changelog for more details ## References N/A ## Changelog N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
ccharly added a commit
that referenced
this pull request
Sep 25, 2024
## Explanation This is a RC for v208.0.0. See changelog for more details ## References Initial attempt: - #4731 Revert of the failing 208.0.0: - #4733 ## Changelog N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This is a RC for v208.0.0. See changelog for more details
References
N/A
Changelog
N/A
Checklist