Uh oh!
There was an error while loading. Please reload this page.
chore(constraints): allow exceptions for dependency-range consistency - #4772
Merged
legobeat merged 2 commits intoOct 9, 2024
Conversation
legobeatforce-pushed
the
constraints-allow-consistent-dependency-ranges-exception
branch
from
October 9, 2024 05:13
8be8f73 to
d7c7bd1Compare
This was referenced Oct 9, 2024
legobeat
marked this pull request as ready for review
October 9, 2024 05:21
legobeatforce-pushed
the
constraints-allow-consistent-dependency-ranges-exception
branch
from
October 9, 2024 05:22
d7c7bd1 to
4502883Compare8 tasks
legobeatforce-pushed
the
constraints-allow-consistent-dependency-ranges-exception
branch
from
October 9, 2024 20:39
ae521de to
f23be0cCompareMrtenz
reviewed
Oct 9, 2024
Comment on lines
+728
to
+730
| const ALLOWED_INCONSISTENT_DEPENDENCIES = Object.entries({ | ||
| // '@metamask/foo': ['^1.0.0'], | ||
| }); |
Member
There was a problem hiding this comment.
Should this be near the top of the file?
ContributorAuthor
There was a problem hiding this comment.
I'm thinking co-locating is clearer (esp since other exceptions are also currently inlined) but I will move it out of the function body in a follow-up!
ContributorAuthor
There was a problem hiding this comment.
ContributorAuthor
There was a problem hiding this comment.
Mrtenz
approved these changes
Oct 9, 2024
Mrtenz
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Based on the conversation on Slack, it seems like the wallet framework team agrees with this change as well.
legobeat
deleted the
constraints-allow-consistent-dependency-ranges-exception
branch
October 9, 2024 21:08
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This allows adding explicit exceptions for the Yarn constraint
expectConsistentDependenciesAndDevDependencies.An exception entry consists of a package name and a set of exact version ranges to be ignored in checking.
This is useful when we have "repo-circular" dependencies, where package A (in this repo) depends on package B (in another repo), which in its turn depends on package C (back again in this repo), finally depending on some package D.
In some cases, bumping D atomically in the monorepo makes things very heavy-handed. This change allows to slice it up in such situations.
References
C = @metamask/json-rpc-engineD = @metamask/rpc-errorsChangelog
None
Checklist