Skip to content

Release 245.0.0 - #4915

Merged
bergeron merged 38 commits into
mainfrom
release/245.0.0
Nov 12, 2024
Merged

Release 245.0.0#4915
bergeron merged 38 commits into
mainfrom
release/245.0.0

Conversation

@bergeron

@bergeronbergeron commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

This releases the assets controllers. Along with other packages the release tool thought should be included.

@bergeron
bergeron requested review from a team as code ownersNovember 12, 2024 16:48
@bergeron
bergeron requested a review from a teamNovember 12, 2024 16:48
@bergeron

bergeron commented Nov 12, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Merged in #4916 from main which was just cleanup and no actual changes

mcmire
mcmire previously requested changes Nov 12, 2024
View reviewed changes

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! It looks like we might want to include more packages in this release since there are some peer dependency bumps.

Comment threadpackages/accounts-controller/package.json Outdated
Comment threadpackages/controller-utils/CHANGELOG.md Outdated
Comment threadpackages/gas-fee-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/notification-services-controller/CHANGELOG.md Outdated
Comment threadpackages/controller-utils/package.json Outdated
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Comment threadpackages/gas-fee-controller/CHANGELOG.md Outdated
Comment threadpackages/keyring-controller/CHANGELOG.md Outdated
Comment threadpackages/user-operation-controller/CHANGELOG.md Outdated
@bergeron

bergeron commented Nov 12, 2024

Copy link
Copy Markdown
ContributorAuthor

I made controller-utils and network-controller patch releases, and included packages with a peer dependency on keyring-controller in the release.

@socket-security

socket-securityBot commented Nov 12, 2024•
edited
Loading

Copy link
Copy Markdown

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages:npm/@metamask/accounts-controller@18.2.3, npm/@metamask/keyring-controller@17.3.1, npm/@metamask/preferences-controller@13.3.0, npm/@metamask/profile-sync-controller@0.0.0, npm/@metamask/transaction-controller@38.3.0

View full report↗︎

mcmire
mcmire reviewed Nov 12, 2024
View reviewed changes
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md Outdated
Comment threadpackages/network-controller/CHANGELOG.md
Comment threadpackages/notification-services-controller/CHANGELOG.md Outdated
Comment threadpackages/profile-sync-controller/package.json Outdated
Comment threadpackages/signature-controller/CHANGELOG.md Outdated
Comment threadpackages/transaction-controller/package.json
Comment threadpackages/user-operation-controller/CHANGELOG.md Outdated
Comment threadpackages/user-operation-controller/CHANGELOG.md Outdated
bergeronand others added 13 commits November 12, 2024 11:21
@bergeron@mcmire
Update packages/assets-controllers/CHANGELOG.md
f2828ff
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/network-controller/CHANGELOG.md
3d92ad7
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/network-controller/CHANGELOG.md
0ecf2dd
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/network-controller/CHANGELOG.md
f9767ea
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/notification-services-controller/CHANGELOG.md
68ed3ef
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/signature-controller/CHANGELOG.md
23cc432
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/user-operation-controller/CHANGELOG.md
efb0af2
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron
release tx controller
c905700
@bergeron
Merge branch 'release/245.0.0' of github.com:MetaMask/core into relea…
d6bccb8
…se/245.0.0
@bergeron
lint
3c66d7d
@bergeron
changelog
928913b
@bergeron
yarn changelog:validate
6f2154d
@bergeron
yarn
c8cf1ff
mcmire
mcmire reviewed Nov 12, 2024
View reviewed changes
Comment threadpackages/transaction-controller/CHANGELOG.md Outdated
@mcmire
mcmire dismissed their stale reviewNovember 12, 2024 20:04

Issues were fixed.

mcmire
mcmire reviewed Nov 12, 2024
View reviewed changes
Comment threadpackages/accounts-controller/CHANGELOG.md Outdated
Comment threadpackages/preferences-controller/CHANGELOG.md Outdated
Comment threadpackages/profile-sync-controller/CHANGELOG.md Outdated
bergeronand others added 5 commits November 12, 2024 12:07
@bergeron@mcmire
Update packages/accounts-controller/CHANGELOG.md
74c8b6d
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/preferences-controller/CHANGELOG.md
e66c0ec
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron@mcmire
Update packages/profile-sync-controller/CHANGELOG.md
65433a7
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@bergeron
lint
8982402
@bergeron
lint
1545216
mcmire
mcmire approved these changes Nov 12, 2024
View reviewed changes

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your patience in working through this PR.

@bergeron
bergeron merged commit 05bd4c7 into mainNov 12, 2024
@bergeron
bergeron deleted the release/245.0.0 branch November 12, 2024 20:24
@mcmiremcmire mentioned this pull request Apr 29, 2026
Draft
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmiremcmiremcmire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergeron@mcmire