Uh oh!
There was an error while loading. Please reload this page.
Extend release commit pattern - #4977
Merged
Merged
Conversation
A recent release PR was titled ``Release `[version]``` pattern before being merged, but this is not recognized as a valid release commit. So that we do not have to revert this release PR and reapply it, accept this pattern as a valid release commit name.
mcmire
enabled auto-merge (squash)
November 25, 2024 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
A recent release PR was titled
Release `[version]`(without the final space) before being merged, but this is not recognized as a valid release commit.So that we do not have to revert this release PR and reapply it, accept this pattern as a valid release commit name.
References
This was the mistitled release PR: #4969. As you can see here, it did not result in a release when it was merged: https://github.com/MetaMask/core/actions/runs/12017079245
Changelog
(N/A)
Checklist