Uh oh!
There was an error while loading. Please reload this page.
chore: bump @metamask/{keyring-api,eth-snap-keyring} - #5019
Closed
ccharly wants to merge 1 commit into
Closed
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
ccharlyforce-pushed
the
chore/accounts-updates
branch
from
December 3, 2024 16:42
66b43db to
4b829e7Compareccharly
marked this pull request as ready for review
December 3, 2024 17:21
ccharlyforce-pushed
the
chore/accounts-updates
branch
from
December 6, 2024 08:50
4b829e7 to
16ba2baCompareccharly
commented
Dec 6, 2024
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
gantunesr
approved these changes
Dec 6, 2024
bergeron
approved these changes
Dec 6, 2024
Prithpal-Sooriya
approved these changes
Dec 6, 2024
Prithpal-Sooriya
commented
Dec 6, 2024
Contributor
You can take my approval for both notifications and identity teams, as I've worked on those controllers |
ccharly
commented
Dec 11, 2024
ContributorAuthor
Closing in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Bumping to the new major
keyring-apiandeth-snap-keyringthat usests-bridgeas their main building tool.The new
keyring-apialso includes the newlistAccountTransactionskeyring method, which is not yet used anywhere.References
Test PR:
Changelog
@metamask/accounts-controllerkeyring-apito^11.1.0eth-snap-keyringto^6.0.0@metamask/assets-controllerskeyring-apito^11.1.0@metamask/chain-controllerkeyring-apito^11.1.0@metamask/keyring-controllerkeyring-apito^11.1.0@metamask/profile-sync-controllerkeyring-apito^11.1.0Checklist