Skip to content

Fix dec to gwi - #504

Merged
brad-decker merged 1 commit into
draft-gasfee-controllerfrom
fix-dec-to-gwi
Jul 1, 2021
Merged

Fix dec to gwi#504
brad-decker merged 1 commit into
draft-gasfee-controllerfrom
fix-dec-to-gwi

Conversation

@brad-decker

Copy link
Copy Markdown
Contributor

Fixes the decToGwei method by changing toFixed(3) to toFixed(9) and changing BN_1000 to BN_1GWEI_IN_WEI which was '1_000' but is now '1_000_000_000';

@brad-decker
brad-decker requested a review from a team as a code ownerJuly 1, 2021 14:57
@brad-decker
brad-decker changed the base branch from main to draft-gasfee-controllerJuly 1, 2021 14:57
@brad-decker
brad-decker requested review from Gudahtt and danjmJuly 1, 2021 14:57

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker
brad-decker merged commit 1c7862d into draft-gasfee-controllerJul 1, 2021
@brad-decker
brad-decker deleted the fix-dec-to-gwi branch July 1, 2021 15:02
brad-decker added a commit that referenced this pull request Jul 2, 2021
brad-decker added a commit that referenced this pull request Jul 7, 2021
amitabh94 pushed a commit to amitabh94/core that referenced this pull request Jun 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brad-decker@Gudahtt