Uh oh!
There was an error while loading. Please reload this page.
Release 270.0.0 - #5058
Merged
Merged
Conversation
ccharlyforce-pushed
the
release/270.0.0
branch
2 times, most recently
from
December 11, 2024 15:41
188a62d to
0e124e2Compareccharlyforce-pushed
the
release/270.0.0
branch
from
December 11, 2024 15:45
0e124e2 to
2102448Comparemcmire
previously requested changes
Dec 11, 2024
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Just had one comment about accounts-controller that blocks this PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
ccharly
enabled auto-merge (squash)
December 11, 2024 18:44
4 tasks
ccharly added a commit
that referenced
this pull request
Dec 11, 2024
…s) (#5061) ## Explanation Found the same typo than last time, but on another section of the CODEOWNERS. Spotted while doing this release: - #5058 ## References Similar to: - #5029 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Use the new Keyring API layout in related controllers. Some peer dependencies have been removed on the
keyring-controller(but they remain here for theaccounts-controllerfor now).References
N/A
Changelog
N/A
Checklist