Uh oh!
There was an error while loading. Please reload this page.
Add metaswaps API and normalize all gas fee units to dec gwei - #507
Merged
brad-decker merged 4 commits intoJul 1, 2021
Merged
Conversation
brad-decker
marked this pull request as draft
July 1, 2021 18:57
wachunei
reviewed
Jul 1, 2021
Comment on lines
308
to
312
Member
There was a problem hiding this comment.
if we are not tracking error from fetchGasEstimates or fetchLegacyGasPriceEstimates we can just } catch { and rename error2 to error
Base automatically changed from
superior-unit-conversions to
draft-gasfee-controllerJuly 1, 2021 19:33
brad-decker
marked this pull request as ready for review
July 1, 2021 19:38
brad-deckerforce-pushed
the
add-metaswaps-api-to-gas-fee-controller
branch
from
July 1, 2021 19:38
8383700 to
f39df36Comparebrad-decker
commented
Jul 1, 2021
ContributorAuthor
@wachunei rebased to remove the superfulous commit |
brad-decker added a commit
that referenced
this pull request
Jul 2, 2021
brad-decker added a commit
that referenced
this pull request
Jul 7, 2021
amitabh94 pushed a commit
to amitabh94/core
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
fetchLegacyGasPriceEstimatehas been renamed tofetchEthGasPriceEstimatebecause eth_gasPrice is not legacy, it is just a fall back.fetchLegacyGasPriceEstimates(note plurality Estimates) is the method that will return metaswaps API estimates.Non Breaking Changes